Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.32] Add Price out of market warning to the Your orders table #2205

Closed
elena-zh opened this issue Mar 28, 2023 · 1 comment
Closed

[1.32] Add Price out of market warning to the Your orders table #2205

elena-zh opened this issue Mar 28, 2023 · 1 comment
Labels
app:CowSwap CowSwap app Bug Something isn't working limit-order Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

  1. Place two Market orders that can affect a price (I placed 2 orders to sell 50 GNO per BAT). Make sure that you get more than 5% of the price impact
    image.png
  2. Wait till 1 of them is executed --> 2nd order cant be executed as Price is OOM
  3. Check the Your orders table on the Limit orders page

AR: there is no Price OOM message
OOM.png OOM2.png

ER: it would be great to add it

@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working limit-order Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Mar 28, 2023
@alfetopito
Copy link
Collaborator

I think this no longer applies:

  1. Swaps are no longer in this table
  2. If the prices move, the executes at will show the order as out of the market already

I followed the steps in this issue and the indicator shows the order as out of the market
image

@alfetopito alfetopito closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:CowSwap CowSwap app Bug Something isn't working limit-order Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

No branches or pull requests

2 participants