Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.34] Don't show Cancelled notification to a filled order #2350

Closed
elena-zh opened this issue Apr 20, 2023 · 2 comments
Closed

[1.34] Don't show Cancelled notification to a filled order #2350

elena-zh opened this issue Apr 20, 2023 · 2 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP

Comments

@elena-zh
Copy link

  1. Place a market order
  2. Open Your orders table
  3. Press on the order menu, press Cancel order
  4. Select 'Onchain' cancellation
  5. Request the cancellation in 5-10 seconds

AR: more likely the order will be filled. But then, 'Cancel order' pop-up may appear when Cancel TX is moned

ER: don't show the Cancelled pop-up when an order is filled.
@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system labels Apr 20, 2023
@elena-zh elena-zh added the TWAP label Jul 26, 2023
@elena-zh
Copy link
Author

Adding TWAP label to the issue as it is also reproducible there.

@elena-zh
Copy link
Author

Duplicate of #1746

@elena-zh elena-zh marked this as a duplicate of #1746 Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elena-zh