Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.35] No warning text when cancel all orders #2421

Closed
elena-zh opened this issue May 4, 2023 · 0 comments
Closed

[1.35] No warning text when cancel all orders #2421

elena-zh opened this issue May 4, 2023 · 0 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Trivial Issues with trivial priority

Comments

@elena-zh
Copy link
Contributor

elena-zh commented May 4, 2023

Edge cases wehn try cancelling:

  1. Already filled order
  2. Expired order

Steps:

  1. Place several orders using EOA wallet
  2. Go to the Limit orders page
  3. Press on the cancel all button
  4. Send the TX to the wallet, but not confirm it until one of the cancelling orders is executed/expired
  5. Sign cancelling TX in the wallet

AR: user gets an empty warning
cancel apready filled.png
ER: the message should be displayed:

  • order is fully filled
  • order is expiredalready traded.pngScreenshot_8.png
@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Trivial Issues with trivial priority labels May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Trivial Issues with trivial priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elena-zh