Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Network param is not changed when cancel the request in MM #2454

Closed
elena-zh opened this issue May 12, 2023 · 1 comment
Closed

URL Network param is not changed when cancel the request in MM #2454

elena-zh opened this issue May 12, 2023 · 1 comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

Reported in #2452 (comment) , but is reproducible on Prod as well

  1. When I paste (not change, copy and paste) the link into the browser, and I'm connected,
    1

and the network does not match (100)
2. I get the request to change the network in the connected wallet
3. When I cancel it
2
4. The network indicator is not returned to the currently connected one
3
5. When I switch the network using the URL (type it) again, I see the previous request in the MM:
4

Expected: return back the network indicator when cancel the change network request in the wallet.

@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system labels May 12, 2023
@elena-zh elena-zh changed the title URL Network param is not changes when cancel the request in MM URL Network param is not changed when cancel the request in MM May 19, 2023
@elena-zh
Copy link
Author

elena-zh commented May 19, 2023

One more way to reproduce the issue (reported in #2490 (comment)):
I can endup in a state where the url says one thing while the app says another

image

Not introduced with this PR, but I thought it was fixing it

To reproduce:

  1. Connect to MM
  2. Change the chain id in the url
  3. Cancel the change in MM
  4. Repeat steps 2 and 3
  • The URL will remain in the new chain while the app remains in the old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

No branches or pull requests

1 participant