Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.48.0] WC doesn't disconnect #3209

Closed
alfetopito opened this issue Oct 12, 2023 · 4 comments
Closed

[1.48.0] WC doesn't disconnect #3209

alfetopito opened this issue Oct 12, 2023 · 4 comments
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional RELEASE Included in the release that is being closed Wallets Wallet related

Comments

@alfetopito
Copy link
Collaborator

Description
WC v2 doesn't want to disconnect, so I can't re-connect it with a new wallet.

How to Reproduce
Steps to reproduce the behavior:

  1. Connect using WC v2
  2. Disconnect
  3. Try to connect again
  4. Nothing happens
  5. Try to connect again
  6. Modal hangs
  7. Refresh the page
  8. WC is connected again
  9. Repeat 1 - 8
  10. Same thing

Expected behavior

  1. When I ask to disconnect, the connection is really gone
  2. When I try to connect again, I'm able to

Screenshots

Screen.Recording.2023-10-12.at.11.32.12.mov

Additional context
While testing release 1.48.0 #3203
@alfetopito alfetopito added the RELEASE Included in the release that is being closed label Oct 12, 2023
@alfetopito
Copy link
Collaborator Author

Not always able to reproduce it.

@alfetopito alfetopito added the Bug Something isn't working label Oct 13, 2023
@elena-zh
Copy link

elena-zh commented Dec 1, 2023 •
edited
Loading

One more issue with disconnect feature: CoW Swap does not show disconnected state when close connection from the wallet. To reproduce:

  1. Connect to a wallet using WC
  2. Open a connected wallet, disconnect CoW Swap from there
  3. Check the CoW Swap app --> it still shows connection. However, should be disconnected.
  4. When disconnect and try connecing another wallet, it reconnets to the previous wallet
  5. After several tries, it leads to the app crash
    image

@elena-zh elena-zh added Low Severity indicator for defects. It won't cause any major break-down of the system Wallets Wallet related labels Dec 1, 2023
@anxolin
Copy link
Contributor

anxolin commented Dec 20, 2023

I also faced this one. The problem is that my WC stopped working (my wallet stopped receiving messages). So i said, ok I will disconnect and connect again. But I can.

This can block the user, so raising this to medium prio.

@anxolin anxolin added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional and removed Low Severity indicator for defects. It won't cause any major break-down of the system labels Dec 20, 2023
@elena-zh
Copy link

Looks like is fixed in #4420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional RELEASE Included in the release that is being closed Wallets Wallet related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alfetopito @anxolin @elena-zh