Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.48.0] Bad error handling posting orders #3217

Closed
anxolin opened this issue Oct 12, 2023 · 1 comment · Fixed by #3224
Closed

[1.48.0] Bad error handling posting orders #3217

anxolin opened this issue Oct 12, 2023 · 1 comment · Fixed by #3224
Assignees
Labels
Bug Something isn't working Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt RELEASE Included in the release that is being closed

Comments

@anxolin
Copy link
Contributor

anxolin commented Oct 12, 2023

Description
We have two important issues when we place an order:

  • Error handling: in some situations, we show an empty dialog
  • Bad handling of some known errors in the API. Like QuoteNotFound

image

How to Reproduce

  1. Sen an order to SWAP in your wallet
  2. Wait for 2.5 min
  3. Sign it

Expected behavior

  1. Never have a broken screen. At least inform about the error.

  2. Handle the expiration of the quote, and ask the user to accept the new one. Ideally, we would auto-accept if the price is equal or better

Additional context
This is the error I got and would be nice to handle better

{
    "errorType": "QuoteNotFound",
    "description": "could not find quote with the specified ID"
}

Additional info

@shoom3301 says this is not from this release, and @alfetopito reported some feedback we think is related to this.

I consider this should be fixed ASAP as its breaking the normal flow of the user: https://cowservices.slack.com/archives/C03S445V822/p1696898447500789

@anxolin anxolin added Bug Something isn't working Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt RELEASE Included in the release that is being closed labels Oct 12, 2023
@alfetopito alfetopito self-assigned this Oct 12, 2023
@alfetopito
Copy link
Collaborator

I got the nice screen both with MM in the browser and another EOA via WCv2

image

@alfetopito alfetopito changed the title Bad error handling posting orders [1.48.0] Bad error handling posting orders Oct 13, 2023
@alfetopito alfetopito assigned shoom3301 and unassigned alfetopito Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt RELEASE Included in the release that is being closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants