Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1Inch: 'Add token to MM' button is displayed on the Confirm order modal in the integrated browser #322

Closed
anxolin opened this issue Apr 2, 2022 · 2 comments
Closed

1Inch: 'Add token to MM' button is displayed on the Confirm order modal in the integrated browser #322

anxolin opened this issue Apr 2, 2022 · 2 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Good-first-task Low Severity indicator for defects. It won't cause any major break-down of the system Wallets Wallet related

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 2, 2022

  1. Open 1Inch wallet in the mobile app
  2. Open the integrated browser there
  3. Connect to the Cowswap
  4. Place an order
  5. Verify the order confirmation modal

AR: 'Add token to MM' button is displayed on the Confirm order modal
image.png
ER: no such button in the 1Inch integrated browser

Original issue gnosis/cowswap#2548 by @elena-zh
@anxolin anxolin added Low Severity indicator for defects. It won't cause any major break-down of the system Wallets Wallet related app:CowSwap CowSwap app Bug Something isn't working labels Apr 2, 2022
@elena-zh elena-zh mentioned this issue Apr 6, 2022
Merged
@fairlighteth
Copy link
Contributor

To add to this issue: Might be an opportunity to create a client/wallet agnostic 'Add Token' component. In this case it's the 'Add to MetaMask' component. But perhaps there are more that have different methods exposed to add a token (1INCH, Tally?).

@elena-zh
Copy link

elena-zh commented Apr 6, 2022

To add to this issue: Might be an opportunity to create a client/wallet agnostic 'Add Token' component. In this case it's the 'Add to MetaMask' component. But perhaps there are more that have different methods exposed to add a token (1INCH, Tally?).

More details are here #378 (comment)

@elena-zh elena-zh added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional and removed Low Severity indicator for defects. It won't cause any major break-down of the system labels Apr 6, 2022
@alfetopito alfetopito mentioned this issue May 20, 2022
Closed
@elena-zh elena-zh added Low Severity indicator for defects. It won't cause any major break-down of the system and removed Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Feb 10, 2023
@elena-zh elena-zh closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Good-first-task Low Severity indicator for defects. It won't cause any major break-down of the system Wallets Wallet related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anxolin @fairlighteth @elena-zh