feat(permit): remove permit related feature flags #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
approved these changes
Nov 3, 2023
alfetopito
force-pushed
the
permit/load-pre-generated-permit-info
branch
from
e9df6b2 to
15ad18f
Compare
Base automatically changed from
permit/load-pre-generated-permit-info
to
develop
November 3, 2023 15:03
alfetopito
force-pushed
the
permit/remove-feature-flags
branch
from
9119e6b to
c7d15f5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove permit related feature flags
Permit is already enabled in prod, no longer need the feature flags.
Even for gnosis chain - which is currently not enabled - there's at least one token identified as permittable
So it should be safe to enable it there as well.
Further work is still needed to fix it for other tokens, but it should be fine.
To Test