Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.50.0] App requires a gasless approval when a token is approved #3423

Closed
elena-zh opened this issue Nov 23, 2023 · 2 comments
Closed

[v1.50.0] App requires a gasless approval when a token is approved #3423

elena-zh opened this issue Nov 23, 2023 · 2 comments
Assignees
@shoom3301
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link
Contributor

elena-zh commented Nov 23, 2023 •
edited
Loading

Reported in https://cowservices.slack.com/archives/C06002PRF37/p1700669625624939?thread_ts=1700661106.495829&cid=C06002PRF37

and in #3417 (comment) (case 2)

Steps:

  1. Open the app
  2. Make sure that you have at least 1 token approved using onchain method, and that is on the gasless approval token list.
  3. Specify a trade with this token
  4. Press on the Swap/Limit

AR: the app requires to sign a gasless approval for the token
image

ER: no approval is needed
@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Nov 23, 2023
@elena-zh elena-zh mentioned this issue Nov 23, 2023
Merged
2 tasks
@shoom3301
Copy link
Collaborator

Thank you! Fixed in #3417

@shoom3301 shoom3301 self-assigned this Dec 5, 2023
@elena-zh
Copy link
Contributor Author

elena-zh commented Dec 5, 2023

LGTM!

@elena-zh elena-zh closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoom3301 shoom3301

Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shoom3301 @elena-zh