Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.50.0] 'Approve' button does not disappear in 10 sec on Swap page #3426

Closed
elena-zh opened this issue Nov 23, 2023 · 2 comments
Closed

[v1.50.0] 'Approve' button does not disappear in 10 sec on Swap page #3426

elena-zh opened this issue Nov 23, 2023 · 2 comments
Assignees
@shoom3301
Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

Related to #3417

  1. Select a token (not in the list of gasless approval tokens) to trade on Swap page
  2. Specify a trade
  3. Press on the Approve button and execute the TX

AR: Approve button is displayed up to 1 minute after the TX is executed

ER: Approve button is displayed up to 1o sec

Note: not reproducible on Limit orders page
@elena-zh elena-zh added Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system labels Nov 23, 2023
@shoom3301 shoom3301 mentioned this issue Dec 4, 2023
Merged
2 tasks
@shoom3301
Copy link
Collaborator

Thanks @elena-zh !
Fixed in #3417

@shoom3301 shoom3301 self-assigned this Dec 4, 2023
@elena-zh
Copy link
Author

elena-zh commented Dec 5, 2023

LGTM!

@elena-zh elena-zh closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoom3301 shoom3301

Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shoom3301 @elena-zh