Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap Zero Fee #3468

Closed
shoom3301 opened this issue Dec 5, 2023 · 0 comments · Fixed by #3469
Closed

Swap Zero Fee #3468

shoom3301 opened this issue Dec 5, 2023 · 0 comments · Fixed by #3469
Assignees
Labels

Comments

@shoom3301
Copy link
Collaborator

Description
This is a part of "Solver Computed Fees" CIP.
Technically, we should change swap orders fee structure to make it the same with limit orders.

We can start working on the CORE which is keeping UI the same, but changing what the user signs:
- Changing fee to be zero
- Making sell amount to be the full sell amount (before was sell amount minus fee)
- Changing the buy amount to be = (sell amount - current fee) * Theoretical price ( 1-slippage)

Docs
https://www.notion.so/cownation/2023-10-Swap-as-Limit-orders-fee-0-5a00548015a14c9f939b934cb5e33309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant