Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.51] Limit orders: Not enough allowance warning for a gasless approved token #3480

Closed
elena-zh opened this issue Dec 6, 2023 · 0 comments
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional RELEASE Included in the release that is being closed

Comments

@elena-zh
Copy link

elena-zh commented Dec 6, 2023

  1. Place a Limit order with a gasless approval token
  2. Revoke a token approval

OR

  1. Place a Swap order (with a gasless approval in one TX)
  2. While Swap order is pending, place limit order
  3. Check Your orders table

AR: there is a 'Not enough approval' warning
approve
not approved

ER: no warning for orders with a gasless approval tokens

@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional RELEASE Included in the release that is being closed labels Dec 6, 2023
@elena-zh elena-zh changed the title [1.51] Limit orders: Not enough allowance warning for a gasless approval token [1.51] Limit orders: Not enough allowance warning for a gasless approved token Dec 6, 2023
@elena-zh elena-zh closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional RELEASE Included in the release that is being closed
Projects
None yet
Development

No branches or pull requests

1 participant