Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning for order with permittable token when revoke approval #3491

Closed
elena-zh opened this issue Dec 7, 2023 · 1 comment
Closed

Show warning for order with permittable token when revoke approval #3491

elena-zh opened this issue Dec 7, 2023 · 1 comment
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

elena-zh commented Dec 7, 2023 •
edited
Loading

Reported in #3487 (review)
Discussion: https://cowservices.slack.com/archives/C06002PRF37/p1701952161428029

Steps:

  1. Place 2 the same limit orders with a permittable token one after another
  2. Wait till the 1st one is filled
  3. Revoke a token approval when the 2nd order is pending

AR: there is no warning for an order that it will not be executed
image

ER: the warning should appear
@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Dec 7, 2023
@elena-zh
Copy link
Author

Should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elena-zh