Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buy orders are broken for fee=0 #3504

Closed
anxolin opened this issue Dec 12, 2023 · 0 comments
Closed

Buy orders are broken for fee=0 #3504

anxolin opened this issue Dec 12, 2023 · 0 comments
Labels
Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt RELEASE Included in the release that is being closed

Comments

@anxolin
Copy link
Contributor

anxolin commented Dec 12, 2023

Description
Buy orders are broken for fee=0

How to Reproduce

Steps to reproduce the behavior:

  1. (https://dev.swap.cow.fi/#/1/swap/WETH/DAI
  2. Set your slippage tolerance to 50% (for dramatic effect)
  3. Check the values you get buying 15 DAI in mainnet using USDC
  4. MAX SENT (inc fee) value should be what the user sign as buy amount, however they sign a way smaller amount making the order unfeasable. It will not execute

Expected behavior
Use max sent (inc. fee) in buy amount

Screenshots
image

image
@anxolin anxolin added Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt RELEASE Included in the release that is being closed labels Dec 12, 2023
@shoom3301 shoom3301 mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alfetopito @anxolin