Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWAP receipt shows warning for same recipient #3517

Closed
alfetopito opened this issue Dec 15, 2023 · 1 comment · Fixed by #5208
Closed

TWAP receipt shows warning for same recipient #3517

alfetopito opened this issue Dec 15, 2023 · 1 comment · Fixed by #5208
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@alfetopito
Copy link
Collaborator

Description

For a scheduled TWAP part order, we show the order recipient warning, even though it matches the order owner.

image

The filled order has no warning:

image

There’s no pending order to confirm what’s the behaviour there, though.

From Martin’s order, using Sasha’s draft PR https://app.safe.global/apps/open?safe=gno%3A0x42cEDde51198D1773590311E2A340DC06B24cB37&appUrl=https%3A%2F%2Fswap-dev-git-fix-twap-order-id-cowswap.vercel.app

From this thread

@alfetopito alfetopito added the Bug Something isn't working label Dec 15, 2023
@elena-zh
Copy link

Might be related to #3497 (at least, would be great to fix this all together)

@elena-zh elena-zh added the Medium Severity indicator. It causes some undesirable behavior, but the system is still functional label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants