Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reset connection to MM when cancel network switch request #3541

Closed
elena-zh opened this issue Dec 21, 2023 · 0 comments · Fixed by #3544
Closed

Don't reset connection to MM when cancel network switch request #3541

elena-zh opened this issue Dec 21, 2023 · 0 comments · Fixed by #3544
Assignees
@shoom3301
Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Regression Wallets Wallet related

Comments

@elena-zh
Copy link

When I connect to MM, it always forces me to change the chain to the one that is selected in the CoW. If I don't want to, connection fails.

image
image

Expected:
the connection should not fail. CoW Swap changes the network to the one in the wallet
@elena-zh elena-zh added Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Wallets Wallet related labels Dec 21, 2023
@elena-zh elena-zh changed the title Don't reset connection when cancel network switch request Don't reset connection to MM when cancel network switch request Dec 21, 2023
@shoom3301 shoom3301 self-assigned this Dec 21, 2023
@shoom3301 shoom3301 mentioned this issue Dec 21, 2023
Merged
@shoom3301 shoom3301 mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoom3301 shoom3301

Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Regression Wallets Wallet related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wallets): don't request network change when connect injected wallet cowprotocol/cowswap
2 participants
@shoom3301 @elena-zh