Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explorer] Fee=0 market order identified as limit #3623

Closed
alfetopito opened this issue Jan 12, 2024 · 0 comments · Fixed by #3635
Closed

[Explorer] Fee=0 market order identified as limit #3623

alfetopito opened this issue Jan 12, 2024 · 0 comments · Fixed by #3635
Labels
Bug Something isn't working Explorer RELEASE Included in the release that is being closed

Comments

@alfetopito
Copy link
Collaborator

Description

A Fee=0 sell market order is incorrectly identified as limit.

How to Reproduce
Steps to reproduce the behavior:

  1. Go to dev.swap.cow.fi
  2. Place a sell SWAP order
  3. Open dev.explorer.cow.fi for this order
  4. It's classified as limit

Expected behavior

Should be a market order, matching the appData
@alfetopito alfetopito added Bug Something isn't working Explorer RELEASE Included in the release that is being closed labels Jan 12, 2024
@shoom3301 shoom3301 mentioned this issue Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Explorer RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add lost changes from prev repo (PR #720) cowprotocol/cowswap
1 participant
@alfetopito