Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Settings Widget #3664

Open
fairlighteth opened this issue Jan 16, 2024 · 1 comment
Open

Unify Settings Widget #3664

fairlighteth opened this issue Jan 16, 2024 · 1 comment
Labels
app:CowSwap CowSwap app Design Design related Enhancement New feature or request

Comments

@fairlighteth
Copy link
Contributor

Description
Right now the Settings Widget differs between Swap and Limit/Twap. Would be good to unify the widget/styles used here:

  • Swap -> apps/cowswap-frontend/src/legacy/components/Settings/index.tsx
  • Limit orders -> apps/cowswap-frontend/src/modules/limitOrders/containers/SettingsWidget/index.tsx
  • Advanced/TWAP -> apps/cowswap-frontend/src/modules/advancedOrders/containers/AdvancedOrdersSettings/index.tsx
Screenshot 2024-01-16 at 12 25 50 Screenshot 2024-01-16 at 12 25 42 Screenshot 2024-01-16 at 12 25 33
@fairlighteth fairlighteth changed the title Unify SettingsWidget Unify Settings Widget Jan 16, 2024
@fairlighteth fairlighteth added app:CowSwap CowSwap app Enhancement New feature or request labels Jan 16, 2024
@elena-zh elena-zh added the Design Design related label Jan 16, 2024
@elena-zh
Copy link

Hey @fairlighteth , is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Design Design related Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fairlighteth @elena-zh