Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inquiry Regarding the Removal of Ledger Connector in CowSwap Wallet Connection Module #3682

Closed
danielstone25 opened this issue Jan 19, 2024 · 3 comments

Comments

@danielstone25
Copy link

Hello team,

I hope this message finds you well. As a web3 developer with a keen interest in the CowSwap project, I recently came across the wallet connection module and was particularly impressed with its functionality. However, I noticed that the Ledger connector, which was previously available, had been removed.

I would like to kindly inquire about the rationale behind this decision. Understanding the thought process behind the removal of the Ledger connector would greatly assist me in comprehending the project's development direction and inform my own work.

I appreciate the hard work and dedication put into the CowSwap project and would be grateful for any insights you can provide on this matter.

Thank you for your time and consideration.

Best regards,
Daniel.

@alfetopito
Copy link
Collaborator

Hello Daniel, thank you for your interest.

It has been removed in light of this https://www.ledger.com/blog/security-incident-report.

Let us know if there is any extra info you'd like.

@danielstone25
Copy link
Author

Thanks for your reply.
So what do you think if you revert the removal and replace ledger/connect-kit-loader with ledger/connect-kit (according to https://github.com/LedgerHQ/connect-kit/tree/main/packages/connect-kit-loader#-important-notice-) then it might work again?

@alfetopito
Copy link
Collaborator

We are not interested in adding the direct ledger connection back at this point.
We might reconsider if there's user demand, but that's not the case so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants