Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWAP page is too wide when place an order with >30 parts #3683

Closed
elena-zh opened this issue Jan 19, 2024 · 1 comment · Fixed by #3895
Closed

TWAP page is too wide when place an order with >30 parts #3683

elena-zh opened this issue Jan 19, 2024 · 1 comment · Fixed by #3895
Assignees
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional TWAP

Comments

@elena-zh
Copy link

elena-zh commented Jan 19, 2024

Reported in https://cowservises.slack.com/archives/C0361CDG8GP/p1705598065623679

Such order can be found in https://app.safe.global/apps/open?safe=gor:0xe9B79591E270B3bCd0CC7e84f7B7De74BA3D0E2F&appUrl=https%3A%2F%2Fswap.cow.fi
See the image:
image

Internal pagination is not collapsed and causes this issue.

Expected: TWAP area is not changed.

@elena-zh elena-zh added Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP labels Jan 19, 2024
@elena-zh elena-zh changed the title TWAP page is too ling when place an order with >30 parts TWAP page is too long when place an order with >30 parts Jan 19, 2024
@anxolin
Copy link
Contributor

anxolin commented Jan 19, 2024

Thanks! it looks terrible.

We will limit the pages we show at a given time. Thanks @elena-zh

@anxolin anxolin added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional and removed Low Severity indicator for defects. It won't cause any major break-down of the system labels Jan 29, 2024
@anxolin anxolin changed the title TWAP page is too long when place an order with >30 parts TWAP page is too wide when place an order with >30 parts Feb 8, 2024
@shoom3301 shoom3301 self-assigned this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional TWAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants