-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solvers page #3721
Comments
Hey @alongoni , great job!
Btw, I'd love to see these screens in a mobile/tablet views Thanks! |
On the other hand, I like it where it is :)
I'm not sure. The environment is an identifier and almost feels like fits better with the name. For the solvers page https://user-images.githubusercontent.com/622217/177876121-7acc534a-944d-414f-bde3-85ac19474f47.png What about having the content in tabs? For the solver details page https://user-images.githubusercontent.com/622217/177876127-2ac5ac21-2c95-442b-9936-fe8761cd211d.png |
Also for the solver details page the current active status. We talked with @GabrielCamba yesterday about handling correctly the isSolver flag in the User entity. Right now we are not tracking active->inactive events, as well as the timestamp where the solver became active |
Thanks for the feedback Elena and Leandro!. Design updated + a Figma prototype |
Thanks Agustin. I left comments directly on the figma file |
design updated: |
Sorry for a late review of this great proposal. In general i like the direction. I'll try to mention some thoughts I have:
BONUS, i add some query i used to check some info. Although, as mentioned, this is not last version, all the cost/volumes are missing https://thegraph.com/hosted-service/subgraph/cowprotocol/cow
|
Thanks for the feedback @anxolin |
Hey @alongoni , great job!
Thank you!! |
I have transferred issue in order not to loose mockups/discussions/etc. |
Closing for now. Can be reopened once re-prioritized |
Lol! Since 2022 this has been open, it was about time. Thanks @elena-zh |
Description
Create a Solvers page.
Data from:
Inspiration: https://dune.com/cowprotocol/GPv2-Solver-Info
The text was updated successfully, but these errors were encountered: