Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hooks] Permit hook is not added to a swap order #4727

Closed
elena-zh opened this issue Jul 17, 2024 · 1 comment
Closed

[hooks] Permit hook is not added to a swap order #4727

elena-zh opened this issue Jul 17, 2024 · 1 comment
Assignees
Labels
Bug Something isn't working Hooks store Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link
Contributor

elena-zh commented Jul 17, 2024

Introduced in #4859

  1. Place an order with a permittable token (not approved) through Hooks form
  2. While this order is Open, go to the swap page and place an order with the same token pair.

AR: there are 2 possible outcomes:

  1. The app requires me to sign a permit request once again
  2. The app does not allow me to place the order due to 'insufficient allowance' error
  3. in both cases I see error fetching permit data on console.

permit
куйгшкуы

Expected: permit should be applied to a swap order

@elena-zh elena-zh added Bug Something isn't working Hooks store labels Jul 17, 2024
@elena-zh elena-zh changed the title [hooks] Pre-hook is not added to a Limit order [hooks] Permit hook is not added to a swap order Sep 11, 2024
@elena-zh elena-zh added the Medium Severity indicator. It causes some undesirable behavior, but the system is still functional label Sep 11, 2024
@elena-zh
Copy link
Contributor Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Hooks store Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

No branches or pull requests

2 participants