Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooks are not added to appdata when connected to a SC wallet #4874

Closed
elena-zh opened this issue Sep 11, 2024 · 0 comments · Fixed by #4875
Closed

Hooks are not added to appdata when connected to a SC wallet #4874

elena-zh opened this issue Sep 11, 2024 · 0 comments · Fixed by #4875
Assignees
@shoom3301
Labels
Bug Something isn't working Hooks store Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link
Contributor

Related to #4859

  1. Open the app inside Safe (or connect to any other SC wallet)
  2. Go to Hooks tab
  3. Add a pre-hook
  4. Place an order

AR: there is no pre-hook in the appdata
image
image

ER: pre-hook should be present.
@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Hooks store labels Sep 11, 2024
@elena-zh elena-zh mentioned this issue Sep 11, 2024
Merged
@shoom3301 shoom3301 mentioned this issue Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoom3301 shoom3301

Labels
Bug Something isn't working Hooks store Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(hooks-store): ignore permit data for sc wallets cowprotocol/cowswap
2 participants
@shoom3301 @elena-zh