-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Curve Tokenlists #4894
Add Curve Tokenlists #4894
Conversation
Add curve tokenlists for ethereum, arbitrum and gnosis
@bout3fiddy is attempting to deploy a commit to the cow Team on Vercel. A member of the Team first needs to authorize it. |
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
on request, removed 'enabledByDefault'
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bout3fiddy , thank you for adding token lists!
However, I don't see these lists added to Ethereum and Arbitrum networks, only to Gnosis. Could you please check this?
@elena-zh does it work in incognito mode? |
No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the list code, I see that all versions are set to 1.0.0
.
Is this updated when the list is updated?
If not, it'll cause issues, since it relies on that to identify when the list should be updated or not.
See the reference https://github.com/Uniswap/token-lists?tab=readme-ov-file#semantic-versioning
There is an error in the list:
@elena-zh p.s. you can find it in the console logs |
So, the problem in the token with name |
p.s. we use this schema for lists validation |
Hi! Just having a look at these. I'll make the required changes and submit. Weird token name. I'll get to the version updating as well. |
@shoom3301 I see that the Name has a max length of 60 and not 40? |
@bout3fiddy hi! |
Add curve tokenlists for ethereum, arbitrum and gnosis
on request, removed 'enabledByDefault'
@elena-zh The PR was updated, now everything is great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
Add curve tokenlists for ethereum, arbitrum and gnosis
Summary
Adds Curve tokenlists to cowswap's frontend. At the moment i've specified them to be set by default (why would i want anything else?). but we can debate this no problems.
The tokenlists are generated via: https://github.com/curvefi/curve-assets
the flow is:
To Test
go to urls specified:
Ethereum tokenlist
Arbitrum tokenlist
Gnosis tokenlist
Background
I'd like tigher integration between Curve markets and cowswap and this is one step along that direction.