Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Va cowamm banner #4981

Merged
merged 24 commits into from
Oct 23, 2024
Merged

Va cowamm banner #4981

merged 24 commits into from
Oct 23, 2024

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Oct 11, 2024

Summary

  • Creates a unified CoW AMM banner component that can serve different variations depending on location of usage. For now global and tokenSelector are the two available locations.
  • DEMO only dropdown activated for this PR
  • Includes click analytics events
Screen.Recording.2024-10-15.at.16.43.14.mov
Screen.Recording.2024-10-15.at.16.41.23.mov

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos 🔄 Building (Inspect) Visit Preview Oct 23, 2024 7:26am
cowfi 🔄 Building (Inspect) Visit Preview Oct 23, 2024 7:26am
explorer-dev 🔄 Building (Inspect) Visit Preview Oct 23, 2024 7:26am
swap-dev 🔄 Building (Inspect) Visit Preview Oct 23, 2024 7:26am
widget-configurator 🔄 Building (Inspect) Visit Preview Oct 23, 2024 7:26am

@fairlighteth
Copy link
Contributor Author

@elena-zh thank you for reviewing this:

  1. Fixed
  2. Fixed
  3. Done intentionally
  4. Yes correct, fixed now
  5. Balancer supports these networks, which we all cover (except for Sepolia, but that's just for testing anyway...)
Screenshot 2024-10-18 at 14 24 25

So in reference to point 4, right now we only show the banners for networks we support in our UI.

@elena-zh
Copy link
Contributor

elena-zh commented Oct 18, 2024

@fairlighteth , thank you!

To clarify the 5th case I reported above:
We don't have CoW AMM pools on Sepolia on Prod (however, it is a supported network).
Same as for other sources.
My question was more about what message should we show on the CoW AMM banner in this case?

@fairlighteth
Copy link
Contributor Author

@elena-zh for now I think we show the general message, which would link you to CoW AMM balancer's page. For now I wouldn't make the message to specific saying "Switch to Ethereum and explore pools" etc.

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved then! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants