Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS broken on Limit Order #5084

Closed
greenlucid opened this issue Nov 13, 2024 · 4 comments · Fixed by #5103
Closed

CSS broken on Limit Order #5084

greenlucid opened this issue Nov 13, 2024 · 4 comments · Fixed by #5103
Labels
Bug Something isn't working Design Design related

Comments

@greenlucid
Copy link

greenlucid commented Nov 13, 2024

To reproduce:

  1. Open Limit orders page
  2. Connect to a wallet
  3. Fill in a Sell token
  4. Pick a LP token that is currently not supported on the UI ( I picked 0xfcd125f4c5030137634863A2d3E5d6D89158f19C on Gnosis chain)
  5. Start typing a price ---> you will get this screen

Cannot even click the X on the green popup
image

image
@greenlucid
Copy link
Author

Swapping the tokens out of order fixes the style. I'd guess the issue is that the symbol length of the token you're buying, was too long. The error only occurs when the long-symbol token is intended to be bought

@elena-zh elena-zh added Bug Something isn't working Design Design related labels Nov 13, 2024
@elena-zh
Copy link

Looks like the same issue as #4867

@greenlucid
Copy link
Author

Good catch, slightly different since that one is about typing in the field. I cannot reproduce it that way. Might be two different issues at the same time (unbounded size on the token picker, and unbounded size on the amount input form)

@elena-zh
Copy link

There are different ways to reproduce this issue, but in terms of the CSS the issue is the same: the UI expands on invalid price/quote. I've added steps to reproduce to the issue description and will let the team know about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Design Design related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants