Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.89] Hooks: Improve Partially fillable order's handling on the UI #5087

Open
elena-zh opened this issue Nov 14, 2024 · 0 comments
Open

[1.89] Hooks: Improve Partially fillable order's handling on the UI #5087

elena-zh opened this issue Nov 14, 2024 · 0 comments
Labels
Bug Something isn't working Hooks store

Comments

@elena-zh
Copy link

Currently, all market orders placed from the Hooks tab are partially fillable.
If an order has a partial fill:

  • Account modal still shows that the order is Open with no fills percentage
    image
  • Order fill pop-up appears only one time on the 1st fill only (not on the 2nd/3rd)
  • TX completed modal appears on the 1st fill only once (but the order has not been fully filled, so we should rethink about all the logic of the success progress bar modal)
  • TX completed modal still has Cancel button
    image
  • ETH-flow order has broken UI (the task related to ETH-flow improvement on the Hooks tab is [1.89] Hooks: selling ETH cases to imrove #4662):
    image
@elena-zh elena-zh added Bug Something isn't working Hooks store labels Nov 14, 2024
@elena-zh elena-zh changed the title Hooks: Improve Partially fillable order's handling on the UI [1.89] Hooks: Improve Partially fillable order's handling on the UI Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Hooks store
Projects
None yet
Development

No branches or pull requests

1 participant