Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.89] Simulation (failed) log is displayed in the Account modal #5092

Closed
elena-zh opened this issue Nov 14, 2024 · 0 comments · Fixed by #5101
Closed

[1.89] Simulation (failed) log is displayed in the Account modal #5092

elena-zh opened this issue Nov 14, 2024 · 0 comments · Fixed by #5101
Labels
Bleu Bug Something isn't working Hooks store Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link
Contributor

  1. Open Hooks tab
  2. Connect to a wallet
  3. Specify any order with a hook added
  4. Place the order
  5. Open Account modal and check the order log

AR: it contains failed simulation result
image

ER: it should not contain a simulation result (no need for already placed/filled/executed/expires orders)
@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bleu Hooks store labels Nov 14, 2024
@yvesfracari yvesfracari mentioned this issue Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bleu Bug Something isn't working Hooks store Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: log simulation only on trade confirmation bleu/cowswap
1 participant
@elena-zh