Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.89] Show a link to simulation result in the confirm modal #5095

Closed
elena-zh opened this issue Nov 14, 2024 · 3 comments
Closed

[1.89] Show a link to simulation result in the confirm modal #5095

elena-zh opened this issue Nov 14, 2024 · 3 comments
Labels
Bleu Bug Something isn't working Hooks store Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

  1. Open Hooks tab, connect to a wallet
  2. Add any hook, specify a swap
  3. Navigate to the Confirm modal

AR: simulation re-runs, but there is no link to a simulation report there
image

ER: the link should be present

@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bleu labels Nov 14, 2024
@yvesfracari
Copy link
Contributor

This was already done on dev and was just not included on prod

image

@elena-zh
Copy link
Author

@yvesfracari , yes, I can see it when I expand a hook details. Not so easy to quickly find it :(
Could you please add the link to a result label itself?
image
More or less similar as we do here:
image

@elena-zh
Copy link
Author

Based on conversation with Pedro: it would be nice to leave this implementation as multiple hooks can be failing at a time, and showing all on them in the confirm modal will clutter the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bleu Bug Something isn't working Hooks store Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

No branches or pull requests

2 participants