Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hooks] Re-run simulation on a slippage change #5129

Open
elena-zh opened this issue Nov 25, 2024 · 0 comments
Open

[Hooks] Re-run simulation on a slippage change #5129

elena-zh opened this issue Nov 25, 2024 · 0 comments
Labels
Bleu Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

Reported in #5069 (comment) (case 4)

When I select a max balance for a hook (including a trade amount in the Buy field for a Sell order), then I change a slippage amount (increase it), the simulation is not re-run. But increasing a slippage leads to the receive amount change --> hook will not be executed. Might it be possible to re-run simulation when a slippage value is changed?
image

@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bleu labels Nov 25, 2024
@elena-zh elena-zh changed the title Re-run simulation on a slippage change [Hooks] Re-run simulation on a slippage change Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bleu Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

No branches or pull requests

1 participant