Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.93][Hooks] Confirm modal reloads when simulation is executed #5182

Open
elena-zh opened this issue Dec 11, 2024 · 0 comments
Open

[1.93][Hooks] Confirm modal reloads when simulation is executed #5182

elena-zh opened this issue Dec 11, 2024 · 0 comments
Labels
Bug Something isn't working Hooks store

Comments

@elena-zh
Copy link

elena-zh commented Dec 11, 2024

  1. Open Hooks tab (enable it in the Swap settings)
  2. Add a pre/post hook into an order (I add a hook related to CoW AMM)
  3. Once all the data is loaded (also, it looks like it is reloaded several times), press on the Swap button
  4. Check the Confirm modal

AR: Confirm modal reloads several times with 'Price updated' message

image
image
image

ER: it is weird that this is happening each time when I open Confrim modal with a hook.
Show a loader when a simulation runs and then shows an final state of the Confirm modal?

@elena-zh elena-zh added Bug Something isn't working Hooks store labels Dec 11, 2024
@elena-zh elena-zh changed the title [Hooks] Confirm modal reloads when simulation is executed [1.93][Hooks] Confirm modal reloads when simulation is executed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Hooks store
Projects
None yet
Development

No branches or pull requests

1 participant