Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOA: no insufficient approval warning for PF order with allowance <0.05% #5210

Closed
elena-zh opened this issue Dec 16, 2024 · 1 comment
Closed

EOA: no insufficient approval warning for PF order with allowance <0.05% #5210

elena-zh opened this issue Dec 16, 2024 · 1 comment
Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

  1. Go to the LImit orders page
  2. Pick non-permittable token to sell
  3. Place a partially-fillable limit order with this token
  4. Once placed, change the sell token's approval to be <0.05% of the sell amount
  5. Check the order details

AR: there is no 'insufficient allowance' order for this order
eoa approval less than 0 05

ER: it should be displayed for a partially fillable order (when allowance is less than 0.05% of the sell amount)
@elena-zh elena-zh added Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system labels Dec 16, 2024
@elena-zh
Copy link
Author

Fixed in #5207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elena-zh