Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network selector #5264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Network selector #5264

wants to merge 2 commits into from

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Dec 31, 2024

Summary

This PR:

  • Delete the feature flag from isBaseEnabled
  • Add a NEW badge in base, to show is a new network
image image

CTX: https://cowservices.slack.com/archives/C06G1E3AU77/p1735549193334069

The message of BASE launch has been long enough.

image

The NEW badge is less annoying

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 31, 2024 10:58am
cowfi ✅ Ready (Inspect) Visit Preview Dec 31, 2024 10:58am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 31, 2024 10:58am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 31, 2024 10:58am
swap-dev ✅ Ready (Inspect) Visit Preview Dec 31, 2024 10:58am
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 31, 2024 10:58am

Comment on lines -16 to +21
// 1. Load feature flag for chain being enabled
const { isBaseEnabled } = useFeatureFlags()
// // 1. Load feature flag for chain being enabled
// const { isBaseEnabled } = useFeatureFlags()

// return useMemo(
// // 2. Conditionally build a list of chain ids to exclude
// () => getAvailableChains(isBaseEnabled ? undefined : [SupportedChainId.BASE]),
// [isBaseEnabled],
// )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why again? #5234

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see..., I did it in main branch. This is not in prod?

@anxolin anxolin requested a review from a team January 2, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants