Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show details of what you sign #626

Closed
anxolin opened this issue Jun 3, 2022 · 0 comments
Closed

Show details of what you sign #626

anxolin opened this issue Jun 3, 2022 · 0 comments

Comments

@anxolin
Copy link
Contributor

anxolin commented Jun 3, 2022

Description
When you sign an order using EIP-712, users will sign a JSON blob. Some wallets might present it nicer, like a table of fields and values, however this is not very user readable.

This is what they see:

image

Proposal
Show more details on what you are signing. Ideally, it would be nice to show the user in the modal how the parameters (in human readable way) maps to that JSON blob they sign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants