Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Don't take protocol fee for in-market limit orders #2092

Closed
1 task
sunce86 opened this issue Nov 28, 2023 · 1 comment
Closed
1 task

feat: Don't take protocol fee for in-market limit orders #2092

sunce86 opened this issue Nov 28, 2023 · 1 comment
Assignees
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Nov 28, 2023

Problem

We don't want to take protocol fees for limit orders with in-market price.

Suggested solution

Don't define protocol fee policies for limit orders with in-market price. To determine if the price is in-market or out-of-market, already existing functionality can be used: https://github.com/cowprotocol/services/blob/main/crates/autopilot/src/solvable_orders.rs#L558

Additional context

Dependent on #2084 which needs to be tackled first.

Acceptance criteria

  • Protocol fee is not taken for limit orders with in-market price (where price is determined at the moment the order was created).
@sunce86
Copy link
Contributor Author

sunce86 commented Jan 12, 2024

Done #2250

@sunce86 sunce86 closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Development

No branches or pull requests

2 participants