Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename fee_policies to protocol_fee #2256

Closed
sunce86 opened this issue Jan 9, 2024 · 0 comments · Fixed by #2274
Closed

chore: Rename fee_policies to protocol_fee #2256

sunce86 opened this issue Jan 9, 2024 · 0 comments · Fixed by #2274
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Jan 9, 2024

Background

#2250 (comment)
@sunce86 sunce86 added the E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details label Jan 9, 2024
This was referenced Jan 9, 2024
Merged
Merged
sunce86 added a commit that referenced this issue Jan 12, 2024
@sunce86
Rename fee policies (#2274)
7ba88b2 
# Description
Fixes #2256

Simple renaming from `fee_policies` to `protocol_fees` to make sure the
reader knows that the policies are used for protocol fee calculation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename fee policies cowprotocol/services
1 participant
@sunce86