Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop auction_transaction table #2350

Closed
sunce86 opened this issue Jan 31, 2024 · 0 comments · Fixed by #2359
Closed

chore: drop auction_transaction table #2350

sunce86 opened this issue Jan 31, 2024 · 0 comments · Fixed by #2359
Assignees
@fleupold

Comments

@sunce86
Copy link
Contributor

sunce86 commented Jan 31, 2024

Background

After #2283 being merged, table auction_transaction should be dropped since no longer used.

Would be nice to include #2100 in this cleanup.
@fleupold fleupold self-assigned this Feb 5, 2024
@fleupold fleupold mentioned this issue Feb 5, 2024
Merged
2 tasks
fleupold added a commit that referenced this issue Feb 6, 2024
@fleupold
Cleanup fee db (#2359)
d67cb3d 
# Description
See related issues for context

# Changes

- [x] Drop `auction_transactions` table
- [x] Drop `solver_fee` column (always null now)

## How to test
Run migration locally

## Related Issues

Fixes #2350 & #2100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fleupold fleupold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup fee db cowprotocol/services
2 participants
@fleupold @sunce86