Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove feature gates for verified quotes #2394

Open
MartinquaXD opened this issue Feb 9, 2024 · 4 comments
Open

chore: Remove feature gates for verified quotes #2394

MartinquaXD opened this issue Feb 9, 2024 · 4 comments
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MartinquaXD
Copy link
Contributor

Background

Just a reminder to clean up CLI flags related to verified quotes after we stabilized the features.

Details

  • delete --prefer-verified-quotes flag and prefer verified quotes unconditionally
@MartinquaXD MartinquaXD added the E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details label Feb 9, 2024
@MartinquaXD MartinquaXD mentioned this issue Feb 9, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Apr 10, 2024
@mfw78 mfw78 removed the stale label Apr 12, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jun 13, 2024
@fleupold
Copy link
Contributor

@MartinquaXD is this still outstanding?

@mfw78 mfw78 removed the stale label Jul 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Sep 9, 2024
@fleupold fleupold added good first issue Good for newcomers help wanted Extra attention is needed and removed stale labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:3.2 Verified Quotes See https://github.com/cowprotocol/pm/issues/15 for details good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fleupold @MartinquaXD @mfw78