You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently our bad token detection requires a node that supports trace_many which for example rules out geth. It should be possible to implement a similar logic using helper solidity contracts we use with state overrides.
This would basically trade in the dependency on trace_many with state overrides. But we already have a very big dependency on that so it would be okay. Another downside would be the increased complexity (in terms of implementation and execution).
And finally our goal is to get rid of bad token detection soon-ish anyway so it might not make sense to spend time on the old stuff.
Some of the techniques that might come in handy have been used and described in #1575.
Basically this issue is just a braindump for the idea so we can track it if we actually want to do it.
Acceptance criteria
Bad token detection no longer depends on trace_many.
The text was updated successfully, but these errors were encountered:
MartinquaXD
changed the title
chore: Get rid of trace_callMany dependency in bad token detection
chore: Get rid of trace_many dependency in bad token detection
Feb 19, 2024
Background
Currently our bad token detection requires a node that supports
trace_many
which for example rules outgeth
. It should be possible to implement a similar logic using helper solidity contracts we use with state overrides.This would basically trade in the dependency on
trace_many
with state overrides. But we already have a very big dependency on that so it would be okay. Another downside would be the increased complexity (in terms of implementation and execution).And finally our goal is to get rid of bad token detection soon-ish anyway so it might not make sense to spend time on the old stuff.
Some of the techniques that might come in handy have been used and described in #1575.
Basically this issue is just a braindump for the idea so we can track it if we actually want to do it.
Acceptance criteria
Bad token detection no longer depends on
trace_many
.The text was updated successfully, but these errors were encountered: