Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove temporary configuration for CIP38 #2462

Closed
sunce86 opened this issue Mar 3, 2024 · 0 comments · Fixed by #2582
Closed

chore: Remove temporary configuration for CIP38 #2462

sunce86 opened this issue Mar 3, 2024 · 0 comments · Fixed by #2582
Assignees
@sunce86

Comments

@sunce86
Copy link
Contributor

sunce86 commented Mar 3, 2024 •
edited
Loading

Background

Temporary configuration for:

  1. Switch to rank by surplus rank_by_surplus_date
  2. Reject market orders market_orders_deprecation_date

needs to be removed after 19th of March, once the CIP is live in production.
This was referenced Mar 3, 2024
Closed
Closed
@sunce86 sunce86 self-assigned this Mar 4, 2024
@sunce86 sunce86 mentioned this issue Mar 19, 2024
Merged
sunce86 added a commit that referenced this issue Mar 29, 2024
@sunce86
Market orders deprecation date remove (#2536)
ad8cd1b 
# Description
Removes `market_orders_deprecation_date` as required in
#2462. (no need to remove
`rank_by_surplus_date` just yet)

Once removed, tests started failing, so we need to convert all tests for
market orders to work with limit orders or to remove them if they don't
make sense anymore.

## How to test
Existing tests.
sunce86 added a commit that referenced this issue Mar 29, 2024
@sunce86
Market orders deprecation date remove (#2536)
b626d0b 
# Description
Removes `market_orders_deprecation_date` as required in
#2462. (no need to remove
`rank_by_surplus_date` just yet)

Once removed, tests started failing, so we need to convert all tests for
market orders to work with limit orders or to remove them if they don't
make sense anymore.

## How to test
Existing tests.
@sunce86 sunce86 mentioned this issue Mar 29, 2024
Merged
sunce86 added a commit that referenced this issue Mar 29, 2024
@sunce86
[EASY] Remove rank by surplus config (#2582)
5430414 
# Description
Fixes #2462

## How to test
Existing tests. No change in behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunce86 sunce86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EASY] Remove rank by surplus config cowprotocol/services
1 participant
@sunce86