Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return order execution timestamp #3250

Open
squadgazzz opened this issue Jan 21, 2025 · 1 comment
Open

feat: Return order execution timestamp #3250

squadgazzz opened this issue Jan 21, 2025 · 1 comment

Comments

@squadgazzz
Copy link
Contributor

squadgazzz commented Jan 21, 2025

Problem

Front-end wants to show the time that was spent to execute each order. More specifically, this is required in the /account/<account_address> API.

Suggested solution

Currently, there is no persistent data in the DB. timestamp from the order_events table can't be used since the table gets cleaned up periodically. Although the order_execution table contains a block number, getting its timestamp requires access to an archive RPC node, which might not be the case for some of the chains.

At first glance, the easiest way would be to introduce a new timestamp column in the order_execution table. This can be backfilled using a script with archive nodes for each chain. Maybe, Tenderly can be utilized on networks without archive node access.

Alternatives considered

To be discussed.

Acceptance criteria

/account/<account_address> returns a response with each order execution timestamp. Since the order creation timestamp is already in place, that is only a matter of the front-end team to calculate the order execution time.

@sunce86
Copy link
Contributor

sunce86 commented Jan 21, 2025

If we end up doing this, I would agree with this assessment:

the easiest way would be to introduce a new timestamp column in the order_execution table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants