feat: Correctly handle error screens when the app is offline and allow to open cozy-apps when offline in iOS #1238
+80
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zatteo
approved these changes
Sep 2, 2024
Ldoppea
force-pushed
the
feat/offline_error_screen
branch
from
8eea39d
to
aa2529c
Compare
Ldoppea
force-pushed
the
feat/files_offline
branch
from
71229ad
to
f13cd52
Compare
Ldoppea
force-pushed
the
feat/offline_error_screen
branch
from
aa2529c
to
7331f45
Compare
Ldoppea
force-pushed
the
feat/files_offline
branch
from
f13cd52
to
cceb2b7
Compare
Ldoppea
force-pushed
the
feat/offline_error_screen
branch
2 times, most recently
from
8f13a31
to
2f518b6
Compare
`NetStatusBoundary` is used to display an `offline` error screen when the app is offline Now that we implemented offline mode, we now want to disable the `NetStatusBoundary` for cozy-apps as they should now be accessible when offline `NetStatusBoundary` is kept only on onboarding screens
In a previous commit we changed the return type for `getIndexHtmlForSlug()` We did not change the return objects for every execution paths This commit fixes that
For now offline mode has only been implemented in cozy-home and mespapiers apps This commit prevents other cozy-apps to be opened offline Later we will declare offline support in cozy-apps' manifests, so this hard coded condition is meant to be replaced in the future
Cozy-apps can be opened offline only when they support this mode but also when they have been opened at least one time to retrieve necessary data to make them run offline When those conditions are not met, we want to display an error message to explain the user why the app cannot be opened For now this message is in an Alert form, but later we may want to improve the UI for this part
In iOS, we disabled HttpServer for all cozy-apps as the WebView API may behave differently The side effect is that we cannot open those app when offline as we cannot inject minimal code to make them work without network access So we want to enable HttpServer on those apps when we detect the app to be offline Related PR: #486
Ldoppea
force-pushed
the
feat/files_offline
branch
from
cceb2b7
to
5a9d0ac
Compare
Ldoppea
force-pushed
the
feat/offline_error_screen
branch
from
2f518b6
to
d411dc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetStatusBoundaryis used to display anofflineerror screen whenthe app is offline
Now that we implemented offline mode, we now want to disable the
NetStatusBoundaryfor cozy-apps as they should now be accessible whenoffline
NetStatusBoundaryis kept only on onboarding screens__
In iOS, we disabled HttpServer for all cozy-apps as the WebView API may
behave differently
The side effect is that we cannot open those app when offline as we
cannot inject minimal code to make them work without network access
So we want to enable HttpServer on those apps when we detect the app to
be offline
Related PR: #486