fix(backup): Stop background backup when not supported #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS, it is not supported. On Android, it is supported until Android 11 because android-upload-service uses Service to start foreground task in background which is deprecated since Android 12.
Ldoppea
approved these changes
Sep 4, 2023
| @@ -124,6 +124,20 @@ export const startBackup = async ( | |||
| postUploadLocalBackupConfig.currentBackup.totalMediasToBackupCount, | |||
| message: partialSuccessMessage | |||
| }) | |||
|
|
|||
| await showLocalNotification({ | |||
There was a problem hiding this comment.
nit: The only difference between if and else blocks are only the status, and the title/body translation keys. So you can ease identifying differences by:
let status = 'success'
let titleKey = 'services.backup.notifications.backupSuccessTitle'
let bodyKey = 'services.backup.notifications.backupSuccessBody'
if (partialSuccessMessage) {
status = 'partial_success'
titleKey = 'services.backup.notifications.backupPartialSuccessTitle'
bodyKey = 'services.backup.notifications.backupPartialSuccessBody'
}
await setLastBackup(...)
await showLocalNotification(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS, it is not supported.
On Android, it is supported until Android 11 because android-upload-service uses Service to start foreground task in background which is deprecated since Android 12.