feat: Move SearchEngine to cozy-dataproxy library #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
added a commit
to cozy/cozy-home
that referenced
this pull request
Nov 5, 2024
In cozy/cozy-libs#2603 we renamed some of the API's attributes for better readability This commit adapt to those changes and handle retrocompatibility until the change is deployed in cozy-web-data-proxy Related PR: cozy/cozy-libs#2603 Related PR: cozy/cozy-web-data-proxy#10
paultranvan
reviewed
Nov 6, 2024
| @@ -33,6 +39,8 @@ const dataProxy: DataProxyWorker = { | |||
| doctypes: [FILES_DOCTYPE, CONTACTS_DOCTYPE, APPS_DOCTYPE], | |||
| initialSync: true, | |||
| periodicSync: false, | |||
| syncDebounceDelayInMs: REPLICATION_DEBOUNCE, | |||
| syncDebounceMaxDelayInMs: REPLICATION_DEBOUNCE_MAX_DELAY, | |||
There was a problem hiding this comment.
cozy/cozy-client#1553 must be merged first and new version included in this commit
Ldoppea
added a commit
to cozy/cozy-home
that referenced
this pull request
Nov 6, 2024
In cozy/cozy-libs#2603 we renamed some of the API's attributes for better readability This commit adapt to those changes and handle retrocompatibility until the change is deployed in cozy-web-data-proxy Related PR: cozy/cozy-libs#2603 Related PR: cozy/cozy-web-data-proxy#10
In cozy/cozy-libs#2603 we introduced a new cozy-dataproxy library where the SearchEngine has been moved This commit is responsible to install the new library, the code migration will be done in the following commit Related PR: cozy/cozy-libs#2603
Ldoppea
force-pushed
the
feat/use_cozy-dataproxy_lib
branch
from
4199020
to
ea8d9f8
Compare
In cozy/cozy-libs#2603 we introduced a new cozy-dataproxy library where the SearchEngine has been moved This commit is responsible to remove all Search related code from this project and instead call the new cozy-dataproxy library's API Related PR: cozy/cozy-libs#2603
In cozy/cozy-client#1553 we introduced a new `startReplicationWithDebounce()` method that will be used by the SearchEngine from cozy-dataproxy We want to fine tune this method's behavior by configuring its debounce timings By doing so, all realtime events on searched doctypes will trigger a replication with a 30s debounce and in the case of many multiple realtime events, the maximum debounce would be of 10min Related PR: cozy/cozy-client#1553
`yarn test` requires at least one test to pass but we removed all tests that were related to Search
`cozy-pouch-link` has been upgraded to `50.3.1` in order to retrieve `startReplicationWithDebounce()` method implementation `cozy-client` has been upgraded to `50.3.1` in order to retrieve some typing fixes Related PR: cozy/cozy-client#1553 Related PR: cozy/cozy-client#1556
Ldoppea
force-pushed
the
feat/use_cozy-dataproxy_lib
branch
from
ea8d9f8
to
e15da8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cozy/cozy-libs#2603 we introduced a new cozy-dataproxy library where the SearchEngine has been moved
This commit is responsible to remove all Search related code from this project and instead call the new cozy-dataproxy library's API
Related PR:
startReplicationWithDebounce()method cozy-client#1553