-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for < CMake 3.10? #767
Comments
Deprecation is always a hard subject. What are the CMake version of the popular Linux Distros (I'm thinking about the supported Ubuntu, Debian, Fedora versions in particular) |
Related PR for CMake 3.5 increase: |
Based on the comments here I have implemented the backwards compatible (to 3.5) way in the 2 PRs above |
Any reason you chose 3.12 Abd not 3.11? |
Minimum would have been 3.10, I went with 3.12 since that was the next commonly used I am happy to change it to 3.10 if that would be easier to merge. It was sort of an arbitrary choice. |
Just for reference - according to pkgs.org the minimum version for current distributions is 3.11.4 for Oracle Linux 8, but 3.26.5 is also available there. |
Thanks for looking. Then I suggest to increase the minimum Version to 3.12 and drop support for anything lower. Running with your random number, because of "that was the next commonly used" comment |
Ubuntu 16.04 is supported through 2028 according to this https://ubuntu.com/about/release-cycle It uses cmake 3.5. However its very easy to build 3.31 using cmake 3.5, I suspect most people using Hunter in a serious way have a more recent cmake. Shall I make an MR with just https://www.kitware.com/cmake-3-12-0-available-for-download/ |
New MRs will use a minimum required of 3.10 if it is a hard requirement as the 3.12 was hard to explain in the docs (cmake.rst). Arbitrary decision is fine for a soft requirement but feels like asking for trouble on a hard minimum version (even if it is unlikely there are many people using either <3.10 or <3.12 these days) |
CMake is now warning if you have
cmake_minimum_required(VERSION xxx)
less than 3.10. This makes our builds very noisy as hunter uses 3.5 a lot.Could either make minimum policy 3.12 but still support 3.5
OR
lose support for < 3.10 entirely?
The text was updated successfully, but these errors were encountered: