#531 less qulice suppressions

.github/workflows/mvn.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-20.04, windows-2022, macos-12]
-        java: [11, 13]
+        java: [11, 17]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-java@v1

pom.xml

@@ -267,7 +267,7 @@ SOFTWARE.
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
         <configuration>
-          <argLine>-Duser.language=en -Duser.country=US</argLine>
+          <argLine>@{argLine} -Duser.language=en -Duser.country=US</argLine>
         </configuration>
       </plugin>
     </plugins>
@@ -290,6 +290,7 @@ SOFTWARE.
           <plugin>
             <groupId>com.qulice</groupId>
             <artifactId>qulice-maven-plugin</artifactId>
+            <version>0.21.1</version>
             <configuration>
               <excludes combine.children="append">
                 <exclude>checkstyle:/src/site/resources/.*</exclude>

src/main/java/org/jpeek/App.java

@@ -58,11 +58,9 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.1
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  * @checkstyle ClassFanOutComplexityCheck (500 lines)
  * @checkstyle ExecutableStatementCountCheck (500 lines)
  * @checkstyle NPathComplexityCheck (500 lines)
- * @checkstyle MagicNumberCheck (500 lines)
  * @checkstyle CyclomaticComplexityCheck (500 lines)
  * @checkstyle MethodLengthCheck (500 lines)
  * @checkstyle JavaNCSSCheck (500 lines)

src/main/java/org/jpeek/Header.java

@@ -36,7 +36,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.8
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 public final class Header implements Iterable<Directive> {
 

src/main/java/org/jpeek/Index.java

@@ -44,7 +44,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.6
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class Index implements Iterable<Directive> {
 

src/main/java/org/jpeek/Matrix.java

@@ -44,7 +44,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.6
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class Matrix implements Iterable<Directive> {
 
@@ -141,10 +140,8 @@ private static int rank(final String color) {
         if ("red".equals(color)) {
             rank = 1;
         } else if ("yellow".equals(color)) {
-            // @checkstyle MagicNumber (1 line)
             rank = 3;
         } else {
-            // @checkstyle MagicNumber (1 line)
             rank = 5;
         }
         return rank;

src/main/java/org/jpeek/ReportWithStatistics.java

@@ -41,7 +41,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.16
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class ReportWithStatistics implements XML {
 

src/main/java/org/jpeek/Version.java

@@ -34,7 +34,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.11
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 public final class Version implements Scalar<String> {
 

src/main/java/org/jpeek/XslReport.java

@@ -50,7 +50,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.1
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class XslReport implements Report {
 

src/main/java/org/jpeek/graph/XmlGraph.java

@@ -40,7 +40,6 @@
  *  ClassDataAbstractionCouplingCheck. The class probably needs to be split
  *  into smaller ones, perhaps extracting the maps into separate objects
  *  (extending MapEnvelopes), or maybe the list itself.
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 public final class XmlGraph implements Graph {
 

src/main/java/org/jpeek/skeleton/Classes.java

@@ -48,7 +48,6 @@
  * @see <a href="http://www.pitt.edu/~ckemerer/CK%20research%20papers/MetricForOOD_ChidamberKemerer94.pdf">A packages suite for object oriented design</a>
  * @since 0.27
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class Classes implements Iterable<CtClass> {
 

src/main/java/org/jpeek/skeleton/OpsOf.java

@@ -39,7 +39,6 @@
  * @see <a href="http://www.pitt.edu/~ckemerer/CK%20research%20papers/MetricForOOD_ChidamberKemerer94.pdf">A packages suite for object oriented design</a>
  * @since 0.27
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  * @checkstyle ParameterNumberCheck (500 lines)
  */
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")

src/main/java/org/jpeek/skeleton/Skeleton.java

@@ -55,7 +55,6 @@
  * @see <a href="http://www.pitt.edu/~ckemerer/CK%20research%20papers/MetricForOOD_ChidamberKemerer94.pdf">A packages suite for object oriented design</a>
  * @since 0.23
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 public final class Skeleton {
 

src/main/java/org/jpeek/skeleton/TypesOf.java

@@ -42,7 +42,6 @@
  * @see <a href="http://www.pitt.edu/~ckemerer/CK%20research%20papers/MetricForOOD_ChidamberKemerer94.pdf">A packages suite for object oriented design</a>
  * @since 0.27
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class TypesOf extends SignatureVisitor implements Iterable<Directive> {
 

src/main/java/org/jpeek/skeleton/XmlClass.java

@@ -47,10 +47,8 @@
  * @see <a href="http://www.pitt.edu/~ckemerer/CK%20research%20papers/MetricForOOD_ChidamberKemerer94.pdf">A packages suite for object oriented design</a>
  * @since 0.27
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  * @checkstyle ParameterNumberCheck (500 lines)
  */
-@SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class XmlClass extends ClassVisitor implements Iterable<Directive> {
 
     /**

src/main/java/org/jpeek/web/AsyncReports.java

@@ -45,9 +45,7 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.8
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
-@SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class AsyncReports implements
     BiFunc<String, String, Func<String, Response>> {
 

src/main/java/org/jpeek/web/DyNum.java

@@ -35,7 +35,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.17
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class DyNum extends Number {
 

src/main/java/org/jpeek/web/Dynamo.java

@@ -40,9 +40,7 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.14
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
-@SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class Dynamo implements Region {
 
     @Override

src/main/java/org/jpeek/web/Futures.java

@@ -53,7 +53,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.8
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class Futures implements
     BiFunc<String, String, Future<Func<String, Response>>>, Text {
@@ -85,7 +84,6 @@ final class Futures implements
     Futures(final BiFunc<String, String, Func<String, Response>> func) {
         this.origin = func;
         this.service = Executors.newFixedThreadPool(
-            // @checkstyle MagicNumber (1 line)
             Math.min(Runtime.getRuntime().availableProcessors(), 4),
             new VerboseThreads(Futures.class)
         );
@@ -99,7 +97,6 @@ public Future<Func<String, Response>> apply(final String group,
         final String artifact) {
         final String target = String.format("%s:%s", group, artifact);
         this.queue.put(target, System.currentTimeMillis());
-        // @checkstyle MagicNumber (1 line)
         if (this.times.size() > 1000) {
             this.times.clear();
         }
@@ -157,7 +154,6 @@ public String asString() throws Exception {
             this.queue.size(),
             Runtime.getRuntime().availableProcessors(),
             Thread.getAllStackTraces().keySet().size(),
-            // @checkstyle MagicNumber (3 lines)
             Runtime.getRuntime().freeMemory() / (1024L << 10),
             Runtime.getRuntime().maxMemory() / (1024L << 10),
             Runtime.getRuntime().totalMemory() / (1024L << 10),

src/main/java/org/jpeek/web/Mistakes.java

@@ -49,7 +49,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.8
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class Mistakes {
@@ -120,7 +119,6 @@ public Iterable<Iterable<? extends Directive>> worst() throws IOException {
                         .withScanIndexForward(false)
                         .withIndexName("mistakes")
                         .withConsistentRead(false)
-                        // @checkstyle MagicNumber (1 line)
                         .withLimit(20)
                         .withSelect(Select.ALL_ATTRIBUTES)
                 )
@@ -157,7 +155,6 @@ private void add(final String name, final double diff) throws IOException {
                         "ttl",
                         System.currentTimeMillis()
                             / TimeUnit.SECONDS.toMillis(1L)
-                            // @checkstyle MagicNumber (1 line)
                             + TimeUnit.DAYS.toSeconds(100L)
                     )
                     .with("pos", 0L)

src/main/java/org/jpeek/web/Pages.java

@@ -37,7 +37,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.8
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class Pages implements Func<String, Response> {
 

src/main/java/org/jpeek/web/Reports.java

@@ -53,7 +53,6 @@
  * {@link Futures}.
  *
  * @since 0.7
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class Reports implements BiFunc<String, String, Func<String, Response>> {
 

src/main/java/org/jpeek/web/Results.java

@@ -51,7 +51,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.8
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class Results {
@@ -110,7 +109,6 @@ public void add(final String artifact, final Path dir)
             index.xpath("/index/@score").get(0)
         ).longValue();
         final long rank = (long) ((double) score * (1.0d - diff.doubleValue()));
-        // @checkstyle MagicNumber (1 line)
         if (elements < 100) {
             Logger.info(
                 this, "%d elements NOT saved for %s by %s, rank=%d, score=%d, metrics=%d",
@@ -146,7 +144,6 @@ elements, artifact, new Version().value(), rank, score,
                         "ttl",
                         System.currentTimeMillis()
                             / TimeUnit.SECONDS.toMillis(1L)
-                            // @checkstyle MagicNumber (1 line)
                             + TimeUnit.DAYS.toSeconds(100L)
                     )
             );
@@ -205,7 +202,6 @@ public Iterable<Iterable<? extends Directive>> recent() {
                         .withScanIndexForward(false)
                         .withIndexName("recent")
                         .withConsistentRead(false)
-                        // @checkstyle MagicNumber (1 line)
                         .withLimit(25)
                         .withAttributesToGet("artifact")
                 )
@@ -263,7 +259,6 @@ public Iterable<Iterable<? extends Directive>> all() {
                 )
                 .through(
                     new ScanValve()
-                        // @checkstyle MagicNumber (1 line)
                         .withLimit(1000)
                         .withAttributeToGet(
                             "artifact", "classes", "defects", "version",
@@ -313,7 +308,6 @@ public Iterable<Iterable<Directive>> best() throws IOException {
                         .withScanIndexForward(false)
                         .withIndexName("ranks")
                         .withConsistentRead(false)
-                        // @checkstyle MagicNumber (1 line)
                         .withLimit(20)
                         .withAttributesToGet(
                             "artifact", "score", "diff", "defects",

src/main/java/org/jpeek/web/RsPage.java

@@ -48,7 +48,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.14
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class RsPage extends RsWrap {
 
@@ -79,7 +78,6 @@ final class RsPage extends RsWrap {
      * @param src Sources
      * @return Response
      */
-    @SuppressWarnings("PMD.AvoidDuplicateLiterals")
     private static Response make(final Request req, final String xsl,
         final Scalar<Iterable<XeSource>> src) {
         final Response raw = new RsXembly(

src/main/java/org/jpeek/web/Sigmas.java

@@ -45,9 +45,7 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.17
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
-@SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class Sigmas {
 
     /**
@@ -85,7 +83,6 @@ public void add(final Path dir) throws IOException {
         final int classes = Integer.parseInt(
             index.xpath("/index/metric[1]/classes/text()").get(0)
         );
-        // @checkstyle MagicNumber (1 line)
         if (defects < 0.15d && classes > 200) {
             for (final XML metric : index.nodes("//metric")) {
                 this.add(metric);
@@ -118,7 +115,6 @@ private void add(final XML metric) throws IOException {
                     .with("version", new Version().value())
                     .with("artifact", "?")
                     .with("champions", 0L)
-                    // @checkstyle MagicNumber (2 lines)
                     .with("mean", new DyNum(0.5d).longValue())
                     .with("sigma", new DyNum(0.1d).longValue())
             );

src/main/java/org/jpeek/web/StickyFutures.java

@@ -36,7 +36,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.8
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class StickyFutures
     implements BiFunc<String, String, Future<Func<String, Response>>> {

src/main/java/org/jpeek/web/TkAll.java

@@ -37,7 +37,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.17
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class TkAll implements Take {
 

src/main/java/org/jpeek/web/TkApp.java

@@ -60,7 +60,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.5
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  * @checkstyle ClassFanOutComplexityCheck (500 lines)
  */
 @SuppressWarnings("PMD.UseUtilityClass")
@@ -106,7 +105,6 @@ private static Take make(final Path home) throws IOException {
         );
         final BiFunc<String, String, Func<String, Response>> reports =
             new AsyncReports(
-                // @checkstyle MagicNumber (1 line)
                 new StickyFutures(futures, 100)
             );
         return new TkSslOnly(

src/main/java/org/jpeek/web/TkIndex.java

@@ -38,7 +38,6 @@
  * <p>There is no thread-safety guarantee.
  *
  * @since 0.10
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 final class TkIndex implements Take {
 
@@ -52,7 +51,6 @@ public Response act(final Request req) {
                     new XeDirectives(
                         new Joined<>(
                             new HeadOf<>(
-                                // @checkstyle MagicNumber (1 line)
                                 20, new Results().best()
                             )
                         )
@@ -63,7 +61,6 @@ public Response act(final Request req) {
                     new XeDirectives(
                         new Joined<>(
                             new HeadOf<>(
-                                // @checkstyle MagicNumber (1 line)
                                 25, new Results().recent()
                             )
                         )