From 098c15741f35ccc21996c45ad76d462f3ce33a98 Mon Sep 17 00:00:00 2001 From: Yegor Bugayenko Date: Fri, 5 Aug 2022 11:33:05 +0300 Subject: [PATCH] #531 less qulice suppressions --- .github/workflows/mvn.yml | 2 +- pom.xml | 3 ++- src/main/java/org/jpeek/App.java | 2 -- src/main/java/org/jpeek/Header.java | 1 - src/main/java/org/jpeek/Index.java | 1 - src/main/java/org/jpeek/Matrix.java | 3 --- .../java/org/jpeek/ReportWithStatistics.java | 1 - src/main/java/org/jpeek/Version.java | 1 - src/main/java/org/jpeek/XslReport.java | 1 - src/main/java/org/jpeek/graph/XmlGraph.java | 1 - src/main/java/org/jpeek/skeleton/Classes.java | 1 - src/main/java/org/jpeek/skeleton/OpsOf.java | 1 - .../java/org/jpeek/skeleton/Skeleton.java | 1 - src/main/java/org/jpeek/skeleton/TypesOf.java | 1 - .../java/org/jpeek/skeleton/XmlClass.java | 2 -- src/main/java/org/jpeek/web/AsyncReports.java | 2 -- src/main/java/org/jpeek/web/DyNum.java | 1 - src/main/java/org/jpeek/web/Dynamo.java | 2 -- src/main/java/org/jpeek/web/Futures.java | 4 ---- src/main/java/org/jpeek/web/Mistakes.java | 3 --- src/main/java/org/jpeek/web/Pages.java | 1 - src/main/java/org/jpeek/web/Reports.java | 1 - src/main/java/org/jpeek/web/Results.java | 6 ----- src/main/java/org/jpeek/web/RsPage.java | 2 -- src/main/java/org/jpeek/web/Sigmas.java | 4 ---- .../java/org/jpeek/web/StickyFutures.java | 1 - src/main/java/org/jpeek/web/TkAll.java | 1 - src/main/java/org/jpeek/web/TkApp.java | 2 -- src/main/java/org/jpeek/web/TkIndex.java | 3 --- src/main/java/org/jpeek/web/TkMistakes.java | 2 -- src/main/java/org/jpeek/web/TkReport.java | 3 --- src/main/java/org/jpeek/web/TkUpload.java | 1 - src/main/java/org/jpeek/web/TypedPages.java | 1 - src/test/java/org/jpeek/AppTest.java | 2 -- src/test/java/org/jpeek/FakeBase.java | 1 - src/test/java/org/jpeek/MetricsTest.java | 1 - src/test/java/org/jpeek/XslReportTest.java | 1 - .../java/org/jpeek/graph/DisjointTest.java | 1 - .../java/org/jpeek/graph/XmlGraphTest.java | 1 - .../java/org/jpeek/metrics/Lcom4Test.java | 2 -- src/test/java/org/jpeek/metrics/LormTest.java | 1 - .../java/org/jpeek/skeleton/SkeletonTest.java | 1 - .../java/org/jpeek/skeleton/XmlClassTest.java | 1 - src/test/java/org/jpeek/web/FuturesTest.java | 1 - src/test/java/org/jpeek/web/ReportsTest.java | 1 - src/test/java/org/jpeek/web/TkReportTest.java | 1 - status-reports/2018-12-28.md | 21 ------------------ status-reports/2019-01-11.md | 19 ---------------- status-reports/2019-01-26.md | 20 ----------------- status-reports/2019-02-19.md | 22 ------------------- status-reports/2019-03-30.md | 18 --------------- status-reports/2019-12-05.md | 18 --------------- 52 files changed, 3 insertions(+), 192 deletions(-) delete mode 100644 status-reports/2018-12-28.md delete mode 100644 status-reports/2019-01-11.md delete mode 100644 status-reports/2019-01-26.md delete mode 100644 status-reports/2019-02-19.md delete mode 100644 status-reports/2019-03-30.md delete mode 100644 status-reports/2019-12-05.md diff --git a/.github/workflows/mvn.yml b/.github/workflows/mvn.yml index 1f3367bd..be00e532 100644 --- a/.github/workflows/mvn.yml +++ b/.github/workflows/mvn.yml @@ -13,7 +13,7 @@ jobs: strategy: matrix: os: [ubuntu-20.04, windows-2022, macos-12] - java: [11, 13] + java: [11, 17] steps: - uses: actions/checkout@v2 - uses: actions/setup-java@v1 diff --git a/pom.xml b/pom.xml index 5db6c469..7326db51 100644 --- a/pom.xml +++ b/pom.xml @@ -267,7 +267,7 @@ SOFTWARE. org.apache.maven.plugins maven-surefire-plugin - -Duser.language=en -Duser.country=US + @{argLine} -Duser.language=en -Duser.country=US @@ -290,6 +290,7 @@ SOFTWARE. com.qulice qulice-maven-plugin + 0.21.1 checkstyle:/src/site/resources/.* diff --git a/src/main/java/org/jpeek/App.java b/src/main/java/org/jpeek/App.java index fed4db3c..9cbf5750 100644 --- a/src/main/java/org/jpeek/App.java +++ b/src/main/java/org/jpeek/App.java @@ -58,11 +58,9 @@ *

There is no thread-safety guarantee. * * @since 0.1 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) * @checkstyle ClassFanOutComplexityCheck (500 lines) * @checkstyle ExecutableStatementCountCheck (500 lines) * @checkstyle NPathComplexityCheck (500 lines) - * @checkstyle MagicNumberCheck (500 lines) * @checkstyle CyclomaticComplexityCheck (500 lines) * @checkstyle MethodLengthCheck (500 lines) * @checkstyle JavaNCSSCheck (500 lines) diff --git a/src/main/java/org/jpeek/Header.java b/src/main/java/org/jpeek/Header.java index 26a1c99c..adec5540 100644 --- a/src/main/java/org/jpeek/Header.java +++ b/src/main/java/org/jpeek/Header.java @@ -36,7 +36,6 @@ *

There is no thread-safety guarantee. * * @since 0.8 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ public final class Header implements Iterable { diff --git a/src/main/java/org/jpeek/Index.java b/src/main/java/org/jpeek/Index.java index 8b8371ae..98a4ad73 100644 --- a/src/main/java/org/jpeek/Index.java +++ b/src/main/java/org/jpeek/Index.java @@ -44,7 +44,6 @@ *

There is no thread-safety guarantee. * * @since 0.6 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class Index implements Iterable { diff --git a/src/main/java/org/jpeek/Matrix.java b/src/main/java/org/jpeek/Matrix.java index 5ebb42bd..65b46177 100644 --- a/src/main/java/org/jpeek/Matrix.java +++ b/src/main/java/org/jpeek/Matrix.java @@ -44,7 +44,6 @@ *

There is no thread-safety guarantee. * * @since 0.6 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class Matrix implements Iterable { @@ -141,10 +140,8 @@ private static int rank(final String color) { if ("red".equals(color)) { rank = 1; } else if ("yellow".equals(color)) { - // @checkstyle MagicNumber (1 line) rank = 3; } else { - // @checkstyle MagicNumber (1 line) rank = 5; } return rank; diff --git a/src/main/java/org/jpeek/ReportWithStatistics.java b/src/main/java/org/jpeek/ReportWithStatistics.java index f9ca12d7..d134aac4 100644 --- a/src/main/java/org/jpeek/ReportWithStatistics.java +++ b/src/main/java/org/jpeek/ReportWithStatistics.java @@ -41,7 +41,6 @@ *

There is no thread-safety guarantee. * * @since 0.16 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class ReportWithStatistics implements XML { diff --git a/src/main/java/org/jpeek/Version.java b/src/main/java/org/jpeek/Version.java index e7429458..2963f261 100644 --- a/src/main/java/org/jpeek/Version.java +++ b/src/main/java/org/jpeek/Version.java @@ -34,7 +34,6 @@ *

There is no thread-safety guarantee. * * @since 0.11 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ public final class Version implements Scalar { diff --git a/src/main/java/org/jpeek/XslReport.java b/src/main/java/org/jpeek/XslReport.java index ca652b86..140cb120 100644 --- a/src/main/java/org/jpeek/XslReport.java +++ b/src/main/java/org/jpeek/XslReport.java @@ -50,7 +50,6 @@ *

There is no thread-safety guarantee. * * @since 0.1 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class XslReport implements Report { diff --git a/src/main/java/org/jpeek/graph/XmlGraph.java b/src/main/java/org/jpeek/graph/XmlGraph.java index 2fe95147..5e4af3ca 100644 --- a/src/main/java/org/jpeek/graph/XmlGraph.java +++ b/src/main/java/org/jpeek/graph/XmlGraph.java @@ -40,7 +40,6 @@ * ClassDataAbstractionCouplingCheck. The class probably needs to be split * into smaller ones, perhaps extracting the maps into separate objects * (extending MapEnvelopes), or maybe the list itself. - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ public final class XmlGraph implements Graph { diff --git a/src/main/java/org/jpeek/skeleton/Classes.java b/src/main/java/org/jpeek/skeleton/Classes.java index 7f602f8d..6d6d634e 100644 --- a/src/main/java/org/jpeek/skeleton/Classes.java +++ b/src/main/java/org/jpeek/skeleton/Classes.java @@ -48,7 +48,6 @@ * @see A packages suite for object oriented design * @since 0.27 * @checkstyle AbbreviationAsWordInNameCheck (5 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class Classes implements Iterable { diff --git a/src/main/java/org/jpeek/skeleton/OpsOf.java b/src/main/java/org/jpeek/skeleton/OpsOf.java index 9ae31a62..ccd57cc3 100644 --- a/src/main/java/org/jpeek/skeleton/OpsOf.java +++ b/src/main/java/org/jpeek/skeleton/OpsOf.java @@ -39,7 +39,6 @@ * @see A packages suite for object oriented design * @since 0.27 * @checkstyle AbbreviationAsWordInNameCheck (5 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) * @checkstyle ParameterNumberCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") diff --git a/src/main/java/org/jpeek/skeleton/Skeleton.java b/src/main/java/org/jpeek/skeleton/Skeleton.java index d1c1f1c8..1b973708 100644 --- a/src/main/java/org/jpeek/skeleton/Skeleton.java +++ b/src/main/java/org/jpeek/skeleton/Skeleton.java @@ -55,7 +55,6 @@ * @see A packages suite for object oriented design * @since 0.23 * @checkstyle AbbreviationAsWordInNameCheck (5 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ public final class Skeleton { diff --git a/src/main/java/org/jpeek/skeleton/TypesOf.java b/src/main/java/org/jpeek/skeleton/TypesOf.java index 5634278f..d28a5c48 100644 --- a/src/main/java/org/jpeek/skeleton/TypesOf.java +++ b/src/main/java/org/jpeek/skeleton/TypesOf.java @@ -42,7 +42,6 @@ * @see A packages suite for object oriented design * @since 0.27 * @checkstyle AbbreviationAsWordInNameCheck (5 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class TypesOf extends SignatureVisitor implements Iterable { diff --git a/src/main/java/org/jpeek/skeleton/XmlClass.java b/src/main/java/org/jpeek/skeleton/XmlClass.java index 60778688..ed4a5b41 100644 --- a/src/main/java/org/jpeek/skeleton/XmlClass.java +++ b/src/main/java/org/jpeek/skeleton/XmlClass.java @@ -47,10 +47,8 @@ * @see A packages suite for object oriented design * @since 0.27 * @checkstyle AbbreviationAsWordInNameCheck (5 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) * @checkstyle ParameterNumberCheck (500 lines) */ -@SuppressWarnings("PMD.AvoidDuplicateLiterals") final class XmlClass extends ClassVisitor implements Iterable { /** diff --git a/src/main/java/org/jpeek/web/AsyncReports.java b/src/main/java/org/jpeek/web/AsyncReports.java index e07a0ae9..fea98cda 100644 --- a/src/main/java/org/jpeek/web/AsyncReports.java +++ b/src/main/java/org/jpeek/web/AsyncReports.java @@ -45,9 +45,7 @@ *

There is no thread-safety guarantee. * * @since 0.8 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ -@SuppressWarnings("PMD.AvoidDuplicateLiterals") final class AsyncReports implements BiFunc> { diff --git a/src/main/java/org/jpeek/web/DyNum.java b/src/main/java/org/jpeek/web/DyNum.java index cb52b98b..029b9a52 100644 --- a/src/main/java/org/jpeek/web/DyNum.java +++ b/src/main/java/org/jpeek/web/DyNum.java @@ -35,7 +35,6 @@ *

There is no thread-safety guarantee. * * @since 0.17 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class DyNum extends Number { diff --git a/src/main/java/org/jpeek/web/Dynamo.java b/src/main/java/org/jpeek/web/Dynamo.java index 2082f53f..84f0a64d 100644 --- a/src/main/java/org/jpeek/web/Dynamo.java +++ b/src/main/java/org/jpeek/web/Dynamo.java @@ -40,9 +40,7 @@ *

There is no thread-safety guarantee. * * @since 0.14 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ -@SuppressWarnings("PMD.AvoidDuplicateLiterals") final class Dynamo implements Region { @Override diff --git a/src/main/java/org/jpeek/web/Futures.java b/src/main/java/org/jpeek/web/Futures.java index 5a30262c..6268dbfe 100644 --- a/src/main/java/org/jpeek/web/Futures.java +++ b/src/main/java/org/jpeek/web/Futures.java @@ -53,7 +53,6 @@ *

There is no thread-safety guarantee. * * @since 0.8 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class Futures implements BiFunc>>, Text { @@ -85,7 +84,6 @@ final class Futures implements Futures(final BiFunc> func) { this.origin = func; this.service = Executors.newFixedThreadPool( - // @checkstyle MagicNumber (1 line) Math.min(Runtime.getRuntime().availableProcessors(), 4), new VerboseThreads(Futures.class) ); @@ -99,7 +97,6 @@ public Future> apply(final String group, final String artifact) { final String target = String.format("%s:%s", group, artifact); this.queue.put(target, System.currentTimeMillis()); - // @checkstyle MagicNumber (1 line) if (this.times.size() > 1000) { this.times.clear(); } @@ -157,7 +154,6 @@ public String asString() throws Exception { this.queue.size(), Runtime.getRuntime().availableProcessors(), Thread.getAllStackTraces().keySet().size(), - // @checkstyle MagicNumber (3 lines) Runtime.getRuntime().freeMemory() / (1024L << 10), Runtime.getRuntime().maxMemory() / (1024L << 10), Runtime.getRuntime().totalMemory() / (1024L << 10), diff --git a/src/main/java/org/jpeek/web/Mistakes.java b/src/main/java/org/jpeek/web/Mistakes.java index e68c27b5..f5cab3d3 100644 --- a/src/main/java/org/jpeek/web/Mistakes.java +++ b/src/main/java/org/jpeek/web/Mistakes.java @@ -49,7 +49,6 @@ *

There is no thread-safety guarantee. * * @since 0.8 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") final class Mistakes { @@ -120,7 +119,6 @@ public Iterable> worst() throws IOException { .withScanIndexForward(false) .withIndexName("mistakes") .withConsistentRead(false) - // @checkstyle MagicNumber (1 line) .withLimit(20) .withSelect(Select.ALL_ATTRIBUTES) ) @@ -157,7 +155,6 @@ private void add(final String name, final double diff) throws IOException { "ttl", System.currentTimeMillis() / TimeUnit.SECONDS.toMillis(1L) - // @checkstyle MagicNumber (1 line) + TimeUnit.DAYS.toSeconds(100L) ) .with("pos", 0L) diff --git a/src/main/java/org/jpeek/web/Pages.java b/src/main/java/org/jpeek/web/Pages.java index 907a113b..8bcb81b2 100644 --- a/src/main/java/org/jpeek/web/Pages.java +++ b/src/main/java/org/jpeek/web/Pages.java @@ -37,7 +37,6 @@ *

There is no thread-safety guarantee. * * @since 0.8 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class Pages implements Func { diff --git a/src/main/java/org/jpeek/web/Reports.java b/src/main/java/org/jpeek/web/Reports.java index dbecea00..ea7b4ba2 100644 --- a/src/main/java/org/jpeek/web/Reports.java +++ b/src/main/java/org/jpeek/web/Reports.java @@ -53,7 +53,6 @@ * {@link Futures}. * * @since 0.7 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class Reports implements BiFunc> { diff --git a/src/main/java/org/jpeek/web/Results.java b/src/main/java/org/jpeek/web/Results.java index d81eaf0b..47b8ef63 100644 --- a/src/main/java/org/jpeek/web/Results.java +++ b/src/main/java/org/jpeek/web/Results.java @@ -51,7 +51,6 @@ *

There is no thread-safety guarantee. * * @since 0.8 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") final class Results { @@ -110,7 +109,6 @@ public void add(final String artifact, final Path dir) index.xpath("/index/@score").get(0) ).longValue(); final long rank = (long) ((double) score * (1.0d - diff.doubleValue())); - // @checkstyle MagicNumber (1 line) if (elements < 100) { Logger.info( this, "%d elements NOT saved for %s by %s, rank=%d, score=%d, metrics=%d", @@ -146,7 +144,6 @@ elements, artifact, new Version().value(), rank, score, "ttl", System.currentTimeMillis() / TimeUnit.SECONDS.toMillis(1L) - // @checkstyle MagicNumber (1 line) + TimeUnit.DAYS.toSeconds(100L) ) ); @@ -205,7 +202,6 @@ public Iterable> recent() { .withScanIndexForward(false) .withIndexName("recent") .withConsistentRead(false) - // @checkstyle MagicNumber (1 line) .withLimit(25) .withAttributesToGet("artifact") ) @@ -263,7 +259,6 @@ public Iterable> all() { ) .through( new ScanValve() - // @checkstyle MagicNumber (1 line) .withLimit(1000) .withAttributeToGet( "artifact", "classes", "defects", "version", @@ -313,7 +308,6 @@ public Iterable> best() throws IOException { .withScanIndexForward(false) .withIndexName("ranks") .withConsistentRead(false) - // @checkstyle MagicNumber (1 line) .withLimit(20) .withAttributesToGet( "artifact", "score", "diff", "defects", diff --git a/src/main/java/org/jpeek/web/RsPage.java b/src/main/java/org/jpeek/web/RsPage.java index 282092d2..46b3ba4d 100644 --- a/src/main/java/org/jpeek/web/RsPage.java +++ b/src/main/java/org/jpeek/web/RsPage.java @@ -48,7 +48,6 @@ *

There is no thread-safety guarantee. * * @since 0.14 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class RsPage extends RsWrap { @@ -79,7 +78,6 @@ final class RsPage extends RsWrap { * @param src Sources * @return Response */ - @SuppressWarnings("PMD.AvoidDuplicateLiterals") private static Response make(final Request req, final String xsl, final Scalar> src) { final Response raw = new RsXembly( diff --git a/src/main/java/org/jpeek/web/Sigmas.java b/src/main/java/org/jpeek/web/Sigmas.java index 3b5ffdee..41b44d05 100644 --- a/src/main/java/org/jpeek/web/Sigmas.java +++ b/src/main/java/org/jpeek/web/Sigmas.java @@ -45,9 +45,7 @@ *

There is no thread-safety guarantee. * * @since 0.17 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ -@SuppressWarnings("PMD.AvoidDuplicateLiterals") final class Sigmas { /** @@ -85,7 +83,6 @@ public void add(final Path dir) throws IOException { final int classes = Integer.parseInt( index.xpath("/index/metric[1]/classes/text()").get(0) ); - // @checkstyle MagicNumber (1 line) if (defects < 0.15d && classes > 200) { for (final XML metric : index.nodes("//metric")) { this.add(metric); @@ -118,7 +115,6 @@ private void add(final XML metric) throws IOException { .with("version", new Version().value()) .with("artifact", "?") .with("champions", 0L) - // @checkstyle MagicNumber (2 lines) .with("mean", new DyNum(0.5d).longValue()) .with("sigma", new DyNum(0.1d).longValue()) ); diff --git a/src/main/java/org/jpeek/web/StickyFutures.java b/src/main/java/org/jpeek/web/StickyFutures.java index b4b7d369..8a44bfac 100644 --- a/src/main/java/org/jpeek/web/StickyFutures.java +++ b/src/main/java/org/jpeek/web/StickyFutures.java @@ -36,7 +36,6 @@ *

There is no thread-safety guarantee. * * @since 0.8 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class StickyFutures implements BiFunc>> { diff --git a/src/main/java/org/jpeek/web/TkAll.java b/src/main/java/org/jpeek/web/TkAll.java index 312edf46..ff0e7a64 100644 --- a/src/main/java/org/jpeek/web/TkAll.java +++ b/src/main/java/org/jpeek/web/TkAll.java @@ -37,7 +37,6 @@ *

There is no thread-safety guarantee. * * @since 0.17 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class TkAll implements Take { diff --git a/src/main/java/org/jpeek/web/TkApp.java b/src/main/java/org/jpeek/web/TkApp.java index 7ea30c08..619b0aff 100644 --- a/src/main/java/org/jpeek/web/TkApp.java +++ b/src/main/java/org/jpeek/web/TkApp.java @@ -60,7 +60,6 @@ *

There is no thread-safety guarantee. * * @since 0.5 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) * @checkstyle ClassFanOutComplexityCheck (500 lines) */ @SuppressWarnings("PMD.UseUtilityClass") @@ -106,7 +105,6 @@ private static Take make(final Path home) throws IOException { ); final BiFunc> reports = new AsyncReports( - // @checkstyle MagicNumber (1 line) new StickyFutures(futures, 100) ); return new TkSslOnly( diff --git a/src/main/java/org/jpeek/web/TkIndex.java b/src/main/java/org/jpeek/web/TkIndex.java index 55c04351..faf17835 100644 --- a/src/main/java/org/jpeek/web/TkIndex.java +++ b/src/main/java/org/jpeek/web/TkIndex.java @@ -38,7 +38,6 @@ *

There is no thread-safety guarantee. * * @since 0.10 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class TkIndex implements Take { @@ -52,7 +51,6 @@ public Response act(final Request req) { new XeDirectives( new Joined<>( new HeadOf<>( - // @checkstyle MagicNumber (1 line) 20, new Results().best() ) ) @@ -63,7 +61,6 @@ public Response act(final Request req) { new XeDirectives( new Joined<>( new HeadOf<>( - // @checkstyle MagicNumber (1 line) 25, new Results().recent() ) ) diff --git a/src/main/java/org/jpeek/web/TkMistakes.java b/src/main/java/org/jpeek/web/TkMistakes.java index 89af220e..984b82d1 100644 --- a/src/main/java/org/jpeek/web/TkMistakes.java +++ b/src/main/java/org/jpeek/web/TkMistakes.java @@ -38,7 +38,6 @@ *

There is no thread-safety guarantee. * * @since 0.14 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class TkMistakes implements Take { @@ -52,7 +51,6 @@ public Response act(final Request req) { new XeDirectives( new Joined<>( new HeadOf<>( - // @checkstyle MagicNumber (1 line) 20, new Mistakes().worst() ) ) diff --git a/src/main/java/org/jpeek/web/TkReport.java b/src/main/java/org/jpeek/web/TkReport.java index 60ebf7f1..5a5a47fe 100644 --- a/src/main/java/org/jpeek/web/TkReport.java +++ b/src/main/java/org/jpeek/web/TkReport.java @@ -50,7 +50,6 @@ *

There is no thread-safety guarantee. * * @since 0.5 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class TkReport implements TkRegex { @@ -78,7 +77,6 @@ final class TkReport implements TkRegex { @Override public Response act(final RqRegex req) throws IOException { final Matcher matcher = req.matcher(); - // @checkstyle MagicNumber (1 line) final String path = matcher.group(3); if (path.isEmpty()) { throw new RsForward( @@ -91,7 +89,6 @@ public Response act(final RqRegex req) throws IOException { ) ).apply(path.substring(1)); if (new RsStatus.Base(response).status() == HttpURLConnection.HTTP_NOT_FOUND - // @checkstyle MagicNumber (1 line) && "badge.svg".equals(matcher.group(3))) { final String artifact = String.format( "%s:%s", matcher.group(1), matcher.group(2) diff --git a/src/main/java/org/jpeek/web/TkUpload.java b/src/main/java/org/jpeek/web/TkUpload.java index a7dfd46d..11be469c 100644 --- a/src/main/java/org/jpeek/web/TkUpload.java +++ b/src/main/java/org/jpeek/web/TkUpload.java @@ -41,7 +41,6 @@ *

There is no thread-safety guarantee. * * @since 0.32 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class TkUpload implements Take { diff --git a/src/main/java/org/jpeek/web/TypedPages.java b/src/main/java/org/jpeek/web/TypedPages.java index bbf51250..8bac92c7 100644 --- a/src/main/java/org/jpeek/web/TypedPages.java +++ b/src/main/java/org/jpeek/web/TypedPages.java @@ -35,7 +35,6 @@ *

There is no thread-safety guarantee. * * @since 0.8 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class TypedPages implements Func { diff --git a/src/test/java/org/jpeek/AppTest.java b/src/test/java/org/jpeek/AppTest.java index 0eb897f8..fb6b9108 100644 --- a/src/test/java/org/jpeek/AppTest.java +++ b/src/test/java/org/jpeek/AppTest.java @@ -47,9 +47,7 @@ * Test case for {@link App}. * @since 0.1 * @checkstyle JavadocMethodCheck (500 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ -@SuppressWarnings("PMD.AvoidDuplicateLiterals") public final class AppTest { @Test public void createsXmlReports(@TempDir final Path output) throws IOException { diff --git a/src/test/java/org/jpeek/FakeBase.java b/src/test/java/org/jpeek/FakeBase.java index ff274549..c63359b0 100644 --- a/src/test/java/org/jpeek/FakeBase.java +++ b/src/test/java/org/jpeek/FakeBase.java @@ -40,7 +40,6 @@ * @since 0.2 * @checkstyle AbbreviationAsWordInNameCheck (5 lines) * @checkstyle JavadocMethodCheck (500 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ public final class FakeBase implements Base { diff --git a/src/test/java/org/jpeek/MetricsTest.java b/src/test/java/org/jpeek/MetricsTest.java index 88c1fcbb..4eb7f7ef 100644 --- a/src/test/java/org/jpeek/MetricsTest.java +++ b/src/test/java/org/jpeek/MetricsTest.java @@ -61,7 +61,6 @@ * TwoCommonMethods,LORM,0.26667d * @checkstyle JavadocTagsCheck (500 lines) * @checkstyle JavadocMethodCheck (500 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) * @checkstyle ParameterNumberCheck (500 lines) */ public final class MetricsTest { diff --git a/src/test/java/org/jpeek/XslReportTest.java b/src/test/java/org/jpeek/XslReportTest.java index 201273bd..8e41ec74 100644 --- a/src/test/java/org/jpeek/XslReportTest.java +++ b/src/test/java/org/jpeek/XslReportTest.java @@ -42,7 +42,6 @@ * Test case for {@link XslReport}. * @since 0.4 * @checkstyle JavadocMethodCheck (500 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") public final class XslReportTest { diff --git a/src/test/java/org/jpeek/graph/DisjointTest.java b/src/test/java/org/jpeek/graph/DisjointTest.java index a3eab074..40273731 100644 --- a/src/test/java/org/jpeek/graph/DisjointTest.java +++ b/src/test/java/org/jpeek/graph/DisjointTest.java @@ -53,7 +53,6 @@ public void calculatesDisjointSets() throws Exception { final Graph graph = new FakeGraph( new ListOf<>(one, two, three, four, five, six) ); - // @checkstyle MagicNumberCheck (50 lines) new Assertion<>( "Must build disjoint sets correctly", new Disjoint(graph).value(), diff --git a/src/test/java/org/jpeek/graph/XmlGraphTest.java b/src/test/java/org/jpeek/graph/XmlGraphTest.java index 1959ee53..8c8d04eb 100644 --- a/src/test/java/org/jpeek/graph/XmlGraphTest.java +++ b/src/test/java/org/jpeek/graph/XmlGraphTest.java @@ -39,7 +39,6 @@ /** * Test case for {@link XmlGraph}. * @since 0.30.9 - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class XmlGraphTest { diff --git a/src/test/java/org/jpeek/metrics/Lcom4Test.java b/src/test/java/org/jpeek/metrics/Lcom4Test.java index 0579e91e..c44c6042 100644 --- a/src/test/java/org/jpeek/metrics/Lcom4Test.java +++ b/src/test/java/org/jpeek/metrics/Lcom4Test.java @@ -36,8 +36,6 @@ * "Into how many independent classes can you split this class?" * @since 0.28 * @checkstyle JavadocMethodCheck (500 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) - * @checkstyle MagicNumberCheck (500 lines) */ public final class Lcom4Test { diff --git a/src/test/java/org/jpeek/metrics/LormTest.java b/src/test/java/org/jpeek/metrics/LormTest.java index 5bdbdb5f..8a4c480b 100644 --- a/src/test/java/org/jpeek/metrics/LormTest.java +++ b/src/test/java/org/jpeek/metrics/LormTest.java @@ -32,7 +32,6 @@ * LORM = Logical Relatedness of Methods. * @since 0.28 * @checkstyle JavadocMethodCheck (500 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ final class LormTest { diff --git a/src/test/java/org/jpeek/skeleton/SkeletonTest.java b/src/test/java/org/jpeek/skeleton/SkeletonTest.java index 94f06be9..bb9d10b8 100644 --- a/src/test/java/org/jpeek/skeleton/SkeletonTest.java +++ b/src/test/java/org/jpeek/skeleton/SkeletonTest.java @@ -34,7 +34,6 @@ * @since 0.23 * @checkstyle JavadocMethodCheck (500 lines) */ -@SuppressWarnings("PMD.AvoidDuplicateLiterals") public final class SkeletonTest { @Test diff --git a/src/test/java/org/jpeek/skeleton/XmlClassTest.java b/src/test/java/org/jpeek/skeleton/XmlClassTest.java index 9da58304..de8eb11f 100644 --- a/src/test/java/org/jpeek/skeleton/XmlClassTest.java +++ b/src/test/java/org/jpeek/skeleton/XmlClassTest.java @@ -32,7 +32,6 @@ * @since 0.27 * @checkstyle JavadocMethodCheck (500 lines) */ -@SuppressWarnings("PMD.AvoidDuplicateLiterals") public final class XmlClassTest { @Test diff --git a/src/test/java/org/jpeek/web/FuturesTest.java b/src/test/java/org/jpeek/web/FuturesTest.java index a9f1c3c1..d9b4a882 100644 --- a/src/test/java/org/jpeek/web/FuturesTest.java +++ b/src/test/java/org/jpeek/web/FuturesTest.java @@ -35,7 +35,6 @@ * Test case for {@link Futures}. * @since 0.32 * @checkstyle JavadocMethodCheck (500 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ public final class FuturesTest { diff --git a/src/test/java/org/jpeek/web/ReportsTest.java b/src/test/java/org/jpeek/web/ReportsTest.java index b42d26ea..4350006c 100644 --- a/src/test/java/org/jpeek/web/ReportsTest.java +++ b/src/test/java/org/jpeek/web/ReportsTest.java @@ -44,7 +44,6 @@ * @since 0.8 * @checkstyle JavadocMethodCheck (500 lines) */ -@SuppressWarnings("PMD.AvoidDuplicateLiterals") public final class ReportsTest { @BeforeEach diff --git a/src/test/java/org/jpeek/web/TkReportTest.java b/src/test/java/org/jpeek/web/TkReportTest.java index 88ab3c08..91bf73e0 100644 --- a/src/test/java/org/jpeek/web/TkReportTest.java +++ b/src/test/java/org/jpeek/web/TkReportTest.java @@ -39,7 +39,6 @@ * Test case for {@link TkReport}. * @since 0.23 * @checkstyle JavadocMethodCheck (500 lines) - * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) */ public final class TkReportTest { diff --git a/status-reports/2018-12-28.md b/status-reports/2018-12-28.md deleted file mode 100644 index 799124cf..00000000 --- a/status-reports/2018-12-28.md +++ /dev/null @@ -1,21 +0,0 @@ -Release 0.27 (Metrics corrections) - -Scope Status -* Metrics correction [30%] -* jpeek maven plugin [0%] -* jpeek CI server [0%] -* jpeek IntelliJ plugin [0%] - -Issues: -* Lots of metrics correction tasks that must be fixed, so jpeek won't have any - new feature soon. -* Project does not have REV members. Being a sandbox project cuts veteran - members from taking part in project, but we don't have members with enough reputation to be revisors. -* A lot of project staff is on vacation. -* Project needs funding. Albeit we have some people working for free we still -have a lot of developers with rate above $0. - -Risks -* Jpeek have a lot of metrics correcting tasks, which scares newbies and ends -up not being resolved [3/7] - diff --git a/status-reports/2019-01-11.md b/status-reports/2019-01-11.md deleted file mode 100644 index 8ed6f285..00000000 --- a/status-reports/2019-01-11.md +++ /dev/null @@ -1,19 +0,0 @@ -Release 0.30 - -Scope Status -* Metrics correction [50%] -* jpeek maven plugin [0%] -* jpeek CI server [0%] -* jpeek IntelliJ plugin [0%] - -Issues: -* Lots of metrics correction tasks that must be fixed, so jpeek won't have any - new feature soon. -* A lot of project staff is on vacation. -* Project needs funding. Albeit we have some people working for free we still -have a lot of developers with rate above $0. - -Risks -* Jpeek have a lot of metrics correcting tasks, which scares newbies and ends -up not being resolved [2/7] - diff --git a/status-reports/2019-01-26.md b/status-reports/2019-01-26.md deleted file mode 100644 index 9eae9aa4..00000000 --- a/status-reports/2019-01-26.md +++ /dev/null @@ -1,20 +0,0 @@ -Release 0.28 (Metrics corrections) - -Scope Status -* Metrics correction [35%] -* jpeek maven plugin [0%] -* jpeek CI server [0%] -* jpeek IntelliJ plugin [0%] - -Issues: -* Lots of metrics correction tasks that must be fixed, so jpeek won't have any - new feature soon. -* Project does not have REV members. Being a sandbox project cuts veteran - members from taking part in project, but we don't have members with enough reputation to be revisors. -* A lot of project staff is on vacation. -* Project needs funding. Albeit we have some people working for free we still -have a lot of developers with rate above $0. - -Risks -* Jpeek have a lot of metrics correcting tasks, which scares newbies and ends -up not being resolved [2/7] diff --git a/status-reports/2019-02-19.md b/status-reports/2019-02-19.md deleted file mode 100644 index eb7b5dad..00000000 --- a/status-reports/2019-02-19.md +++ /dev/null @@ -1,22 +0,0 @@ -Release 0.28 (Metrics corrections) - -Scope Status -* Metrics correction [35%] -* jpeek maven plugin [0%] -* jpeek CI server [0%] -* jpeek IntelliJ plugin [0%] - -Issues: -* Lots of metrics correction tasks that must be fixed, so jpeek won't have any - new feature soon. -* Project does not have REV members. Being a sandbox project cuts veteran - members from taking part in project, but we don't have members with enough - reputation to be revisors. -* A lot of project staff is on vacation. -* Project needs funding. Albeit we have some people working for free we still -have a lot of developers with rate above $0. -* Project developers are migrating to funded projects - -Risks -* Jpeek have a lot of metrics correcting tasks, which scares newbies and ends -up not being resolved [2/7] diff --git a/status-reports/2019-03-30.md b/status-reports/2019-03-30.md deleted file mode 100644 index 915cfd54..00000000 --- a/status-reports/2019-03-30.md +++ /dev/null @@ -1,18 +0,0 @@ -Release 0.28 (Metrics corrections) - -Scope Status -* Metrics correction [35%] -* jpeek maven plugin [0%] -* jpeek CI server [0%] -* jpeek IntelliJ plugin [0%] - -Issues: -* Lots of metrics correction tasks that must be fixed, so jpeek won't have any - new feature soon. -* Project does not have REV members. Being a sandbox project cuts veteran - members from taking part in project, but we don't have members with enough reputation to be revisors. -* A lot of project staff is on vacation or inactive. Opened an [issue](https://github.com/zerocracy/farm/issues/1971) in 0crat farm for helping with this - -Risks -* Jpeek have a lot of metrics correcting tasks, which scares newbies and ends -up not being resolved [2/7] diff --git a/status-reports/2019-12-05.md b/status-reports/2019-12-05.md deleted file mode 100644 index 648f043d..00000000 --- a/status-reports/2019-12-05.md +++ /dev/null @@ -1,18 +0,0 @@ -Release 0.30.2 - released in 05/12/2019 - -Scope Status - -1. Metrics correction [35%] -1. jpeek maven plugin [0%] -1. jpeek CI server [0%] -1. jpeek IntelliJ plugin [0%] - -Issues: - -1. Lots of metrics correction tasks that must be fixed, so jpeek won't have any new feature soon. -1. Project does not have REV members. Being a sandbox project cuts veteran members from taking part in project, but we don't have members with enough reputation to be revisors. -1. A lot of project staff is on vacation or inactive. Opened an issue in 0crat farm for helping with this - -Risks - -1. Jpeek have a lot of metrics correcting tasks, which scares newbies and ends up not being resolved [2/7]