From 960db81899c3a3264a32d8a618cac3b954ad7366 Mon Sep 17 00:00:00 2001 From: Gnusin Pavel Date: Sat, 9 Nov 2019 19:53:56 +0300 Subject: [PATCH 1/5] yegor256#308 qulice-maven-plugin version updated to 0.18.19 --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index 79e2fdbd..979c16a7 100644 --- a/pom.xml +++ b/pom.xml @@ -234,6 +234,7 @@ SOFTWARE. com.qulice qulice-maven-plugin + 0.18.19 checkstyle:/src/site/resources/.* From 03aefcd263f4c77bd3c9a4dea447e4b7939b0e9e Mon Sep 17 00:00:00 2001 From: Gnusin Pavel Date: Sun, 10 Nov 2019 21:52:35 +0300 Subject: [PATCH 2/5] yegor256#308 qulice-maven-plugin version updated to 0.18.17 fixed new qulice error --- pom.xml | 2 +- src/main/java/org/jpeek/App.java | 8 ++++++-- src/main/java/org/jpeek/Base.java | 3 ++- src/main/java/org/jpeek/DefaultBase.java | 3 ++- src/main/java/org/jpeek/FileTarget.java | 3 ++- src/main/java/org/jpeek/Header.java | 3 ++- src/main/java/org/jpeek/Index.java | 3 ++- src/main/java/org/jpeek/Main.java | 3 ++- src/main/java/org/jpeek/Matrix.java | 3 ++- src/main/java/org/jpeek/Report.java | 5 ++++- src/main/java/org/jpeek/ReportWithStatistics.java | 3 ++- src/main/java/org/jpeek/Target.java | 3 ++- src/main/java/org/jpeek/Version.java | 3 ++- src/main/java/org/jpeek/package-info.java | 2 +- src/main/java/org/jpeek/skeleton/Classes.java | 12 +++++++----- src/main/java/org/jpeek/skeleton/OpsOf.java | 3 ++- src/main/java/org/jpeek/skeleton/QualifiedName.java | 3 ++- src/main/java/org/jpeek/skeleton/Skeleton.java | 8 ++++++-- src/main/java/org/jpeek/skeleton/TypesOf.java | 3 ++- src/main/java/org/jpeek/skeleton/XmlClass.java | 3 ++- src/main/java/org/jpeek/skeleton/package-info.java | 2 +- src/main/java/org/jpeek/web/AsyncReports.java | 3 ++- src/main/java/org/jpeek/web/DyNum.java | 5 +++-- src/main/java/org/jpeek/web/Dynamo.java | 3 ++- src/main/java/org/jpeek/web/Front.java | 3 ++- src/main/java/org/jpeek/web/Futures.java | 3 ++- src/main/java/org/jpeek/web/Mistakes.java | 3 ++- src/main/java/org/jpeek/web/Pages.java | 3 ++- src/main/java/org/jpeek/web/Reports.java | 4 +++- src/main/java/org/jpeek/web/Results.java | 3 ++- src/main/java/org/jpeek/web/RsPage.java | 3 ++- src/main/java/org/jpeek/web/Sigmas.java | 3 ++- src/main/java/org/jpeek/web/StickyFutures.java | 3 ++- src/main/java/org/jpeek/web/TkAll.java | 3 ++- src/main/java/org/jpeek/web/TkApp.java | 3 ++- src/main/java/org/jpeek/web/TkIndex.java | 3 ++- src/main/java/org/jpeek/web/TkMistakes.java | 3 ++- src/main/java/org/jpeek/web/TkQueue.java | 3 ++- src/main/java/org/jpeek/web/TkReport.java | 3 ++- src/main/java/org/jpeek/web/TypedPages.java | 3 ++- src/main/java/org/jpeek/web/package-info.java | 2 +- src/test/java/org/jpeek/AppTest.java | 3 ++- src/test/java/org/jpeek/DefaultBaseTest.java | 3 ++- src/test/java/org/jpeek/FakeBase.java | 3 ++- src/test/java/org/jpeek/IndexTest.java | 3 ++- src/test/java/org/jpeek/MainTest.java | 3 ++- src/test/java/org/jpeek/MatrixTest.java | 3 ++- src/test/java/org/jpeek/MetricsTest.java | 9 +++++---- src/test/java/org/jpeek/ReportTest.java | 3 ++- .../java/org/jpeek/ReportWithStatisticsTest.java | 3 ++- src/test/java/org/jpeek/metrics/Lcom4Test.java | 3 ++- src/test/java/org/jpeek/metrics/LormTest.java | 3 ++- src/test/java/org/jpeek/metrics/MetricBase.java | 3 ++- src/test/java/org/jpeek/metrics/package-info.java | 2 +- src/test/java/org/jpeek/package-info.java | 2 +- src/test/java/org/jpeek/skeleton/SkeletonTest.java | 3 ++- src/test/java/org/jpeek/skeleton/TypesOfTest.java | 3 ++- src/test/java/org/jpeek/skeleton/XmlClassTest.java | 3 ++- src/test/java/org/jpeek/skeleton/package-info.java | 2 +- src/test/java/org/jpeek/web/AsyncReportsTest.java | 3 ++- src/test/java/org/jpeek/web/DyNumTest.java | 3 ++- src/test/java/org/jpeek/web/MistakesTest.java | 3 ++- src/test/java/org/jpeek/web/PagesTest.java | 3 ++- src/test/java/org/jpeek/web/ReportsTest.java | 3 ++- src/test/java/org/jpeek/web/ResultsTest.java | 3 ++- src/test/java/org/jpeek/web/TkAppTest.java | 3 ++- src/test/java/org/jpeek/web/TkIndexTest.java | 3 ++- src/test/java/org/jpeek/web/TkMistakesTest.java | 3 ++- src/test/java/org/jpeek/web/package-info.java | 2 +- 69 files changed, 150 insertions(+), 79 deletions(-) diff --git a/pom.xml b/pom.xml index 979c16a7..9d422cc9 100644 --- a/pom.xml +++ b/pom.xml @@ -234,7 +234,7 @@ SOFTWARE. com.qulice qulice-maven-plugin - 0.18.19 + 0.18.17 checkstyle:/src/site/resources/.* diff --git a/src/main/java/org/jpeek/App.java b/src/main/java/org/jpeek/App.java index 8d0db262..fdde86e9 100644 --- a/src/main/java/org/jpeek/App.java +++ b/src/main/java/org/jpeek/App.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -67,6 +67,7 @@ * @checkstyle CyclomaticComplexityCheck (500 lines) * @checkstyle MethodLengthCheck (500 lines) * @checkstyle JavaNCSSCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) * * @todo #118:30min LCC metric has impediments (see puzzles in LCC.xml * and in `MetricsTest`). @@ -143,7 +144,10 @@ public App(final Path source, final Path target, * Analyze sources. * @throws IOException If fails */ - @SuppressWarnings("PMD.ExcessiveMethodLength") + @SuppressWarnings({ + "PMD.ExcessiveMethodLength", + "PMD.NcssCount" + }) public void analyze() throws IOException { final Base base = new DefaultBase(this.input); final XML skeleton = new Skeleton(base).xml(); diff --git a/src/main/java/org/jpeek/Base.java b/src/main/java/org/jpeek/Base.java index fe7a41c1..13f663c0 100644 --- a/src/main/java/org/jpeek/Base.java +++ b/src/main/java/org/jpeek/Base.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -34,6 +34,7 @@ * @author Yegor Bugayenko (yegor256@gmail.com) * @version $Id$ * @since 0.1 + * @checkstyle JavadocTagsCheck (500 lines) */ public interface Base { diff --git a/src/main/java/org/jpeek/DefaultBase.java b/src/main/java/org/jpeek/DefaultBase.java index beb796b6..954d8ed7 100644 --- a/src/main/java/org/jpeek/DefaultBase.java +++ b/src/main/java/org/jpeek/DefaultBase.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -37,6 +37,7 @@ * @author Yegor Bugayenko (yegor256@gmail.com) * @version $Id$ * @since 0.1 + * @checkstyle JavadocTagsCheck (500 lines) */ public final class DefaultBase implements Base { diff --git a/src/main/java/org/jpeek/FileTarget.java b/src/main/java/org/jpeek/FileTarget.java index 31c09f8a..6d846ca4 100644 --- a/src/main/java/org/jpeek/FileTarget.java +++ b/src/main/java/org/jpeek/FileTarget.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -36,6 +36,7 @@ * @author Felipe Moreno (oridan@gmail.com) * @version $Id$ * @since 0.26.4 + * @checkstyle JavadocTagsCheck (500 lines) */ public final class FileTarget implements Target { diff --git a/src/main/java/org/jpeek/Header.java b/src/main/java/org/jpeek/Header.java index b275f7e2..5a7a8ed3 100644 --- a/src/main/java/org/jpeek/Header.java +++ b/src/main/java/org/jpeek/Header.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -39,6 +39,7 @@ * @version $Id$ * @since 0.8 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class Header implements Iterable { diff --git a/src/main/java/org/jpeek/Index.java b/src/main/java/org/jpeek/Index.java index 31869798..a5e1c676 100644 --- a/src/main/java/org/jpeek/Index.java +++ b/src/main/java/org/jpeek/Index.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -46,6 +46,7 @@ * @version $Id$ * @since 0.6 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class Index implements Iterable { diff --git a/src/main/java/org/jpeek/Main.java b/src/main/java/org/jpeek/Main.java index 88626235..c60c3d1d 100644 --- a/src/main/java/org/jpeek/Main.java +++ b/src/main/java/org/jpeek/Main.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -43,6 +43,7 @@ * @version $Id$ * @since 0.1 * @checkstyle JavadocVariableCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class Main { diff --git a/src/main/java/org/jpeek/Matrix.java b/src/main/java/org/jpeek/Matrix.java index f24b26f0..c619a3d3 100644 --- a/src/main/java/org/jpeek/Matrix.java +++ b/src/main/java/org/jpeek/Matrix.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -47,6 +47,7 @@ * @version $Id$ * @since 0.6 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class Matrix implements Iterable { diff --git a/src/main/java/org/jpeek/Report.java b/src/main/java/org/jpeek/Report.java index ccb9664f..5a3c689a 100644 --- a/src/main/java/org/jpeek/Report.java +++ b/src/main/java/org/jpeek/Report.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -56,12 +56,14 @@ * @version $Id$ * @since 0.1 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class Report { /** * Default mean. */ private static final double DEFAULT_MEAN = 0.5d; + /** * Default sigma. */ @@ -172,6 +174,7 @@ final class Report { * @param target Target dir * @throws IOException If fails */ + @SuppressWarnings("PMD.GuardLogStatement") public void save(final Path target) throws IOException { final long start = System.currentTimeMillis(); final XML xml = new StrictXML( diff --git a/src/main/java/org/jpeek/ReportWithStatistics.java b/src/main/java/org/jpeek/ReportWithStatistics.java index e08aa9b6..04ae5007 100644 --- a/src/main/java/org/jpeek/ReportWithStatistics.java +++ b/src/main/java/org/jpeek/ReportWithStatistics.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -44,6 +44,7 @@ * @version $Id$ * @since 0.16 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class ReportWithStatistics implements XML { diff --git a/src/main/java/org/jpeek/Target.java b/src/main/java/org/jpeek/Target.java index 6d0093c7..fed4aff5 100644 --- a/src/main/java/org/jpeek/Target.java +++ b/src/main/java/org/jpeek/Target.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -32,6 +32,7 @@ * @author Felipe Moreno (oridan@gmail.com) * @version $Id$ * @since 0.26.4 + * @checkstyle JavadocTagsCheck (500 lines) */ public interface Target { diff --git a/src/main/java/org/jpeek/Version.java b/src/main/java/org/jpeek/Version.java index aa4ae042..d10f7dc5 100644 --- a/src/main/java/org/jpeek/Version.java +++ b/src/main/java/org/jpeek/Version.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -37,6 +37,7 @@ * @version $Id$ * @since 0.11 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class Version implements Scalar { diff --git a/src/main/java/org/jpeek/package-info.java b/src/main/java/org/jpeek/package-info.java index d27678e9..7f90a624 100644 --- a/src/main/java/org/jpeek/package-info.java +++ b/src/main/java/org/jpeek/package-info.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko diff --git a/src/main/java/org/jpeek/skeleton/Classes.java b/src/main/java/org/jpeek/skeleton/Classes.java index e72cfe92..950bf2c5 100644 --- a/src/main/java/org/jpeek/skeleton/Classes.java +++ b/src/main/java/org/jpeek/skeleton/Classes.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -24,7 +24,6 @@ package org.jpeek.skeleton; import com.jcabi.log.Logger; -import java.io.FileInputStream; import java.io.IOException; import java.io.InputStream; import java.nio.file.Files; @@ -51,6 +50,7 @@ * @since 0.27 * @checkstyle AbbreviationAsWordInNameCheck (5 lines) * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class Classes implements Iterable { @@ -74,7 +74,10 @@ final class Classes implements Iterable { } @Override - @SuppressWarnings("PMD.PrematureDeclaration") + @SuppressWarnings({ + "PMD.PrematureDeclaration", + "PMD.GuardLogStatement" + }) public Iterator iterator() { final Collection classes; final long start = System.currentTimeMillis(); @@ -88,8 +91,7 @@ public Iterator iterator() { && !ctClass.getName().matches("^.+\\$AjcClosure[0-9]+$"), new Mapped<>( path -> { - try (InputStream stream = - new FileInputStream(path.toFile())) { + try (InputStream stream = Files.newInputStream(path)) { return this.pool.makeClassIfNew(stream); } }, diff --git a/src/main/java/org/jpeek/skeleton/OpsOf.java b/src/main/java/org/jpeek/skeleton/OpsOf.java index 895ccbe6..bc74fcb1 100644 --- a/src/main/java/org/jpeek/skeleton/OpsOf.java +++ b/src/main/java/org/jpeek/skeleton/OpsOf.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -41,6 +41,7 @@ * @checkstyle AbbreviationAsWordInNameCheck (5 lines) * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) * @checkstyle ParameterNumberCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") final class OpsOf extends MethodVisitor { diff --git a/src/main/java/org/jpeek/skeleton/QualifiedName.java b/src/main/java/org/jpeek/skeleton/QualifiedName.java index 3331fa6f..a1e75dee 100644 --- a/src/main/java/org/jpeek/skeleton/QualifiedName.java +++ b/src/main/java/org/jpeek/skeleton/QualifiedName.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -34,6 +34,7 @@ * @author Ilya Kharlamov (ilya.kharlamov@gmail.com) * @version $Id$ * @since 0.29 + * @checkstyle JavadocTagsCheck (500 lines) */ public final class QualifiedName extends TextEnvelope { /** diff --git a/src/main/java/org/jpeek/skeleton/Skeleton.java b/src/main/java/org/jpeek/skeleton/Skeleton.java index dc4e1b82..b03e773f 100644 --- a/src/main/java/org/jpeek/skeleton/Skeleton.java +++ b/src/main/java/org/jpeek/skeleton/Skeleton.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -59,6 +59,7 @@ * @since 0.23 * @checkstyle AbbreviationAsWordInNameCheck (5 lines) * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class Skeleton { @@ -139,7 +140,10 @@ public XML xml() { * Calculate Xembly for all packages. * @return XML for all packages (one by one) */ - @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops") + @SuppressWarnings({ + "PMD.AvoidInstantiatingObjectsInLoops", + "PMD.GuardLogStatement" + }) private Iterable> packages() { final long start = System.currentTimeMillis(); final Collection> all = diff --git a/src/main/java/org/jpeek/skeleton/TypesOf.java b/src/main/java/org/jpeek/skeleton/TypesOf.java index 8a121df6..552fb4af 100644 --- a/src/main/java/org/jpeek/skeleton/TypesOf.java +++ b/src/main/java/org/jpeek/skeleton/TypesOf.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -45,6 +45,7 @@ * @since 0.27 * @checkstyle AbbreviationAsWordInNameCheck (5 lines) * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class TypesOf extends SignatureVisitor implements Iterable { diff --git a/src/main/java/org/jpeek/skeleton/XmlClass.java b/src/main/java/org/jpeek/skeleton/XmlClass.java index a687aba6..93c78c6d 100644 --- a/src/main/java/org/jpeek/skeleton/XmlClass.java +++ b/src/main/java/org/jpeek/skeleton/XmlClass.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -51,6 +51,7 @@ * @checkstyle AbbreviationAsWordInNameCheck (5 lines) * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) * @checkstyle ParameterNumberCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") final class XmlClass extends ClassVisitor implements Iterable { diff --git a/src/main/java/org/jpeek/skeleton/package-info.java b/src/main/java/org/jpeek/skeleton/package-info.java index 62854402..2270eadd 100644 --- a/src/main/java/org/jpeek/skeleton/package-info.java +++ b/src/main/java/org/jpeek/skeleton/package-info.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko diff --git a/src/main/java/org/jpeek/web/AsyncReports.java b/src/main/java/org/jpeek/web/AsyncReports.java index 73ba01c9..fc9427b2 100644 --- a/src/main/java/org/jpeek/web/AsyncReports.java +++ b/src/main/java/org/jpeek/web/AsyncReports.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -46,6 +46,7 @@ * @version $Id$ * @since 0.8 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class AsyncReports implements BiFunc> { diff --git a/src/main/java/org/jpeek/web/DyNum.java b/src/main/java/org/jpeek/web/DyNum.java index cd22ece8..5ae9450c 100644 --- a/src/main/java/org/jpeek/web/DyNum.java +++ b/src/main/java/org/jpeek/web/DyNum.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -38,13 +38,14 @@ * @version $Id$ * @since 0.17 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class DyNum extends Number { /** * Score multiplier. */ - private static final Double MULTIPLIER = 100000.0d; + private static final Double MULTIPLIER = 100_000.0d; /** * Serialization marker. diff --git a/src/main/java/org/jpeek/web/Dynamo.java b/src/main/java/org/jpeek/web/Dynamo.java index 45b392ba..3cba205f 100644 --- a/src/main/java/org/jpeek/web/Dynamo.java +++ b/src/main/java/org/jpeek/web/Dynamo.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -43,6 +43,7 @@ * @version $Id$ * @since 0.14 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") final class Dynamo implements Region { diff --git a/src/main/java/org/jpeek/web/Front.java b/src/main/java/org/jpeek/web/Front.java index 05a174aa..9f89d115 100644 --- a/src/main/java/org/jpeek/web/Front.java +++ b/src/main/java/org/jpeek/web/Front.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -32,6 +32,7 @@ * @author Yegor Bugayenko (yegor256@gmail.com) * @version $Id$ * @since 0.8 + * @checkstyle JavadocTagsCheck (500 lines) */ interface Front extends Func { } diff --git a/src/main/java/org/jpeek/web/Futures.java b/src/main/java/org/jpeek/web/Futures.java index b8124c1e..8b6f094c 100644 --- a/src/main/java/org/jpeek/web/Futures.java +++ b/src/main/java/org/jpeek/web/Futures.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -49,6 +49,7 @@ * @version $Id$ * @since 0.8 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class Futures implements BiFunc>, Text { diff --git a/src/main/java/org/jpeek/web/Mistakes.java b/src/main/java/org/jpeek/web/Mistakes.java index ad4cf0f7..7ae53a2c 100644 --- a/src/main/java/org/jpeek/web/Mistakes.java +++ b/src/main/java/org/jpeek/web/Mistakes.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -52,6 +52,7 @@ * @version $Id$ * @since 0.8 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") final class Mistakes { diff --git a/src/main/java/org/jpeek/web/Pages.java b/src/main/java/org/jpeek/web/Pages.java index 28779da7..b6c59405 100644 --- a/src/main/java/org/jpeek/web/Pages.java +++ b/src/main/java/org/jpeek/web/Pages.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -38,6 +38,7 @@ * @version $Id$ * @since 0.8 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class Pages implements Front { diff --git a/src/main/java/org/jpeek/web/Reports.java b/src/main/java/org/jpeek/web/Reports.java index 833300ce..991cb84d 100644 --- a/src/main/java/org/jpeek/web/Reports.java +++ b/src/main/java/org/jpeek/web/Reports.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -45,6 +45,7 @@ * @version $Id$ * @since 0.7 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class Reports implements BiFunc { @@ -77,6 +78,7 @@ final class Reports implements BiFunc { } // @checkstyle ExecutableStatementCountCheck (100 lines) + @SuppressWarnings("PMD.CyclomaticComplexity") @Override public Front apply(final String group, final String artifact) throws IOException { diff --git a/src/main/java/org/jpeek/web/Results.java b/src/main/java/org/jpeek/web/Results.java index f5beae4a..35d5d7cf 100644 --- a/src/main/java/org/jpeek/web/Results.java +++ b/src/main/java/org/jpeek/web/Results.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -51,6 +51,7 @@ * @version $Id$ * @since 0.8 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") final class Results { diff --git a/src/main/java/org/jpeek/web/RsPage.java b/src/main/java/org/jpeek/web/RsPage.java index 1b0787d5..ac0ee4d0 100644 --- a/src/main/java/org/jpeek/web/RsPage.java +++ b/src/main/java/org/jpeek/web/RsPage.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -50,6 +50,7 @@ * @version $Id$ * @since 0.14 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class RsPage extends RsWrap { diff --git a/src/main/java/org/jpeek/web/Sigmas.java b/src/main/java/org/jpeek/web/Sigmas.java index d0029c5a..7c156396 100644 --- a/src/main/java/org/jpeek/web/Sigmas.java +++ b/src/main/java/org/jpeek/web/Sigmas.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -48,6 +48,7 @@ * @version $Id$ * @since 0.17 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") final class Sigmas { diff --git a/src/main/java/org/jpeek/web/StickyFutures.java b/src/main/java/org/jpeek/web/StickyFutures.java index 37722442..d0777696 100644 --- a/src/main/java/org/jpeek/web/StickyFutures.java +++ b/src/main/java/org/jpeek/web/StickyFutures.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -37,6 +37,7 @@ * @version $Id$ * @since 0.8 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class StickyFutures implements BiFunc> { diff --git a/src/main/java/org/jpeek/web/TkAll.java b/src/main/java/org/jpeek/web/TkAll.java index f7e79cc6..de4bec09 100644 --- a/src/main/java/org/jpeek/web/TkAll.java +++ b/src/main/java/org/jpeek/web/TkAll.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -40,6 +40,7 @@ * @version $Id$ * @since 0.17 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class TkAll implements Take { diff --git a/src/main/java/org/jpeek/web/TkApp.java b/src/main/java/org/jpeek/web/TkApp.java index 1c429161..c6eab02b 100644 --- a/src/main/java/org/jpeek/web/TkApp.java +++ b/src/main/java/org/jpeek/web/TkApp.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -60,6 +60,7 @@ * @since 0.5 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) * @checkstyle ClassFanOutComplexityCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.UseUtilityClass") public final class TkApp extends TkWrap { diff --git a/src/main/java/org/jpeek/web/TkIndex.java b/src/main/java/org/jpeek/web/TkIndex.java index 9f7ae3ca..44c4fd89 100644 --- a/src/main/java/org/jpeek/web/TkIndex.java +++ b/src/main/java/org/jpeek/web/TkIndex.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -42,6 +42,7 @@ * @version $Id$ * @since 0.10 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class TkIndex implements Take { diff --git a/src/main/java/org/jpeek/web/TkMistakes.java b/src/main/java/org/jpeek/web/TkMistakes.java index a9b9f900..4ea9c1a1 100644 --- a/src/main/java/org/jpeek/web/TkMistakes.java +++ b/src/main/java/org/jpeek/web/TkMistakes.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -42,6 +42,7 @@ * @version $Id$ * @since 0.14 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class TkMistakes implements Take { diff --git a/src/main/java/org/jpeek/web/TkQueue.java b/src/main/java/org/jpeek/web/TkQueue.java index 40af474b..5a06da60 100644 --- a/src/main/java/org/jpeek/web/TkQueue.java +++ b/src/main/java/org/jpeek/web/TkQueue.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -38,6 +38,7 @@ * @author Yegor Bugayenko (yegor256@gmail.com) * @version $Id$ * @since 0.18 + * @checkstyle JavadocTagsCheck (500 lines) */ final class TkQueue implements Take { diff --git a/src/main/java/org/jpeek/web/TkReport.java b/src/main/java/org/jpeek/web/TkReport.java index ade2e421..8a0fe9c8 100644 --- a/src/main/java/org/jpeek/web/TkReport.java +++ b/src/main/java/org/jpeek/web/TkReport.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -43,6 +43,7 @@ * @version $Id$ * @since 0.5 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class TkReport implements TkRegex { diff --git a/src/main/java/org/jpeek/web/TypedPages.java b/src/main/java/org/jpeek/web/TypedPages.java index f46694d0..318ad299 100644 --- a/src/main/java/org/jpeek/web/TypedPages.java +++ b/src/main/java/org/jpeek/web/TypedPages.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -37,6 +37,7 @@ * @version $Id$ * @since 0.8 * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ final class TypedPages implements Front { diff --git a/src/main/java/org/jpeek/web/package-info.java b/src/main/java/org/jpeek/web/package-info.java index b40306c0..26ff996a 100644 --- a/src/main/java/org/jpeek/web/package-info.java +++ b/src/main/java/org/jpeek/web/package-info.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko diff --git a/src/test/java/org/jpeek/AppTest.java b/src/test/java/org/jpeek/AppTest.java index 1292e739..9bcee62d 100644 --- a/src/test/java/org/jpeek/AppTest.java +++ b/src/test/java/org/jpeek/AppTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -48,6 +48,7 @@ * @version $Id$ * @since 0.1 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") public final class AppTest { diff --git a/src/test/java/org/jpeek/DefaultBaseTest.java b/src/test/java/org/jpeek/DefaultBaseTest.java index b58956b7..55c896c5 100644 --- a/src/test/java/org/jpeek/DefaultBaseTest.java +++ b/src/test/java/org/jpeek/DefaultBaseTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -37,6 +37,7 @@ * @version $Id$ * @since 0.1 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class DefaultBaseTest { diff --git a/src/test/java/org/jpeek/FakeBase.java b/src/test/java/org/jpeek/FakeBase.java index d3579083..2e08ffbf 100644 --- a/src/test/java/org/jpeek/FakeBase.java +++ b/src/test/java/org/jpeek/FakeBase.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -43,6 +43,7 @@ * @checkstyle AbbreviationAsWordInNameCheck (5 lines) * @checkstyle JavadocMethodCheck (500 lines) * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class FakeBase implements Base { diff --git a/src/test/java/org/jpeek/IndexTest.java b/src/test/java/org/jpeek/IndexTest.java index 3e8ee2a4..7a28777f 100644 --- a/src/test/java/org/jpeek/IndexTest.java +++ b/src/test/java/org/jpeek/IndexTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -39,6 +39,7 @@ * @version $Id$ * @since 0.6 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class IndexTest { /** diff --git a/src/test/java/org/jpeek/MainTest.java b/src/test/java/org/jpeek/MainTest.java index 46b80ac0..2b73389a 100644 --- a/src/test/java/org/jpeek/MainTest.java +++ b/src/test/java/org/jpeek/MainTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -40,6 +40,7 @@ * @version $Id$ * @since 0.1 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") public final class MainTest { diff --git a/src/test/java/org/jpeek/MatrixTest.java b/src/test/java/org/jpeek/MatrixTest.java index e799d8c6..9b87f1cf 100644 --- a/src/test/java/org/jpeek/MatrixTest.java +++ b/src/test/java/org/jpeek/MatrixTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -39,6 +39,7 @@ * @version $Id$ * @since 0.8 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class MatrixTest { /** diff --git a/src/test/java/org/jpeek/MetricsTest.java b/src/test/java/org/jpeek/MetricsTest.java index cb510d31..7efb25e3 100644 --- a/src/test/java/org/jpeek/MetricsTest.java +++ b/src/test/java/org/jpeek/MetricsTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -56,6 +56,7 @@ * Also, all classes without transitive relations * should have the same LCC metric as TCC metric. * Before do it we have to fix puzzles in LCC.xml. + * @checkstyle JavadocTagsCheck (500 lines) */ @RunWith(Parameterized.class) @SuppressWarnings({"PMD.AvoidDuplicateLiterals", "PMD.ExcessiveMethodLength"}) @@ -218,13 +219,13 @@ public static Collection targets() { new Object[] { "IndirectlyRelatedPairs", "OCC", - 0.6666666666666666d, + 0.6_666_666_666_666_666d, }, new Object[] {"MethodMethodCalls", "OCC", 0.2d}, new Object[] { "MethodsWithDiffParamTypes", "OCC", - 0.3333333333333333d, + 0.3_333_333_333_333_333d, }, new Object[] {"NoMethods", "OCC", 0.0d}, new Object[] {"OneMethodCreatesLambda", "OCC", 0.0d}, @@ -234,7 +235,7 @@ public static Collection targets() { new Object[] {"TwoCommonAttributes", "OCC", 0.0d}, new Object[] {"TwoCommonMethods", "OCC", 0.0d}, new Object[] {"WithoutAttributes", "OCC", 0.0d}, - new Object[] {"TwoCommonMethods", "LORM", 0.26667d} + new Object[] {"TwoCommonMethods", "LORM", 0.26_667d} ); } diff --git a/src/test/java/org/jpeek/ReportTest.java b/src/test/java/org/jpeek/ReportTest.java index d04cd1b6..7323a267 100644 --- a/src/test/java/org/jpeek/ReportTest.java +++ b/src/test/java/org/jpeek/ReportTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -43,6 +43,7 @@ * @since 0.4 * @checkstyle JavadocMethodCheck (500 lines) * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") public final class ReportTest { diff --git a/src/test/java/org/jpeek/ReportWithStatisticsTest.java b/src/test/java/org/jpeek/ReportWithStatisticsTest.java index c2331d6b..7ee49e4d 100644 --- a/src/test/java/org/jpeek/ReportWithStatisticsTest.java +++ b/src/test/java/org/jpeek/ReportWithStatisticsTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -38,6 +38,7 @@ * @version $Id$ * @since 0.19 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class ReportWithStatisticsTest { diff --git a/src/test/java/org/jpeek/metrics/Lcom4Test.java b/src/test/java/org/jpeek/metrics/Lcom4Test.java index cf856e9f..0a5ae29a 100644 --- a/src/test/java/org/jpeek/metrics/Lcom4Test.java +++ b/src/test/java/org/jpeek/metrics/Lcom4Test.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -40,6 +40,7 @@ * @checkstyle JavadocMethodCheck (500 lines) * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) * @checkstyle MagicNumberCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class Lcom4Test { diff --git a/src/test/java/org/jpeek/metrics/LormTest.java b/src/test/java/org/jpeek/metrics/LormTest.java index 1e2c2be6..769fb5c1 100644 --- a/src/test/java/org/jpeek/metrics/LormTest.java +++ b/src/test/java/org/jpeek/metrics/LormTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -35,6 +35,7 @@ * @since 0.28 * @checkstyle JavadocMethodCheck (500 lines) * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class LormTest { @Test diff --git a/src/test/java/org/jpeek/metrics/MetricBase.java b/src/test/java/org/jpeek/metrics/MetricBase.java index c32229ac..3d6fbd8e 100644 --- a/src/test/java/org/jpeek/metrics/MetricBase.java +++ b/src/test/java/org/jpeek/metrics/MetricBase.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -39,6 +39,7 @@ * @author Ilya Kharlamov (ilya.kharlamov@gmail.com) * @version $Id$ * @since 0.28 + * @checkstyle JavadocTagsCheck (500 lines) */ public final class MetricBase { /** diff --git a/src/test/java/org/jpeek/metrics/package-info.java b/src/test/java/org/jpeek/metrics/package-info.java index deadc9a6..d6491653 100644 --- a/src/test/java/org/jpeek/metrics/package-info.java +++ b/src/test/java/org/jpeek/metrics/package-info.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko diff --git a/src/test/java/org/jpeek/package-info.java b/src/test/java/org/jpeek/package-info.java index 1361eea4..5f32b906 100644 --- a/src/test/java/org/jpeek/package-info.java +++ b/src/test/java/org/jpeek/package-info.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko diff --git a/src/test/java/org/jpeek/skeleton/SkeletonTest.java b/src/test/java/org/jpeek/skeleton/SkeletonTest.java index 9e823dd5..7b3831bb 100644 --- a/src/test/java/org/jpeek/skeleton/SkeletonTest.java +++ b/src/test/java/org/jpeek/skeleton/SkeletonTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -40,6 +40,7 @@ * findFieldWithQualifiedName must be uncommented when this issue is * resolved. Please see #156 for more detailing in upgrading skeleton * behavior. + * @checkstyle JavadocTagsCheck (500 lines) */ @SuppressWarnings("PMD.AvoidDuplicateLiterals") public final class SkeletonTest { diff --git a/src/test/java/org/jpeek/skeleton/TypesOfTest.java b/src/test/java/org/jpeek/skeleton/TypesOfTest.java index 6d26af72..551c5399 100644 --- a/src/test/java/org/jpeek/skeleton/TypesOfTest.java +++ b/src/test/java/org/jpeek/skeleton/TypesOfTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -35,6 +35,7 @@ * @version $Id$ * @since 0.27 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class TypesOfTest { diff --git a/src/test/java/org/jpeek/skeleton/XmlClassTest.java b/src/test/java/org/jpeek/skeleton/XmlClassTest.java index fd15eb7c..cada644d 100644 --- a/src/test/java/org/jpeek/skeleton/XmlClassTest.java +++ b/src/test/java/org/jpeek/skeleton/XmlClassTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -36,6 +36,7 @@ * @version $Id$ * @since 0.27 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class XmlClassTest { diff --git a/src/test/java/org/jpeek/skeleton/package-info.java b/src/test/java/org/jpeek/skeleton/package-info.java index 3f5d3fc9..261d0fab 100644 --- a/src/test/java/org/jpeek/skeleton/package-info.java +++ b/src/test/java/org/jpeek/skeleton/package-info.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko diff --git a/src/test/java/org/jpeek/web/AsyncReportsTest.java b/src/test/java/org/jpeek/web/AsyncReportsTest.java index 941718de..0d0d6283 100644 --- a/src/test/java/org/jpeek/web/AsyncReportsTest.java +++ b/src/test/java/org/jpeek/web/AsyncReportsTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -44,6 +44,7 @@ * @version $Id$ * @since 0.8 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class AsyncReportsTest { diff --git a/src/test/java/org/jpeek/web/DyNumTest.java b/src/test/java/org/jpeek/web/DyNumTest.java index fd480b92..70e7dfd2 100644 --- a/src/test/java/org/jpeek/web/DyNumTest.java +++ b/src/test/java/org/jpeek/web/DyNumTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -35,6 +35,7 @@ * @version $Id$ * @since 0.31 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class DyNumTest { diff --git a/src/test/java/org/jpeek/web/MistakesTest.java b/src/test/java/org/jpeek/web/MistakesTest.java index 7b8d40ca..f88a9c8f 100644 --- a/src/test/java/org/jpeek/web/MistakesTest.java +++ b/src/test/java/org/jpeek/web/MistakesTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -42,6 +42,7 @@ * @version $Id$ * @since 0.16 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class MistakesTest { diff --git a/src/test/java/org/jpeek/web/PagesTest.java b/src/test/java/org/jpeek/web/PagesTest.java index bde1058d..2c0b2bec 100644 --- a/src/test/java/org/jpeek/web/PagesTest.java +++ b/src/test/java/org/jpeek/web/PagesTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -37,6 +37,7 @@ * @version $Id$ * @since 0.31 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class PagesTest { diff --git a/src/test/java/org/jpeek/web/ReportsTest.java b/src/test/java/org/jpeek/web/ReportsTest.java index e67e6985..c72f6062 100644 --- a/src/test/java/org/jpeek/web/ReportsTest.java +++ b/src/test/java/org/jpeek/web/ReportsTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -41,6 +41,7 @@ * @version $Id$ * @since 0.8 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class ReportsTest { diff --git a/src/test/java/org/jpeek/web/ResultsTest.java b/src/test/java/org/jpeek/web/ResultsTest.java index 5277e681..107584b3 100644 --- a/src/test/java/org/jpeek/web/ResultsTest.java +++ b/src/test/java/org/jpeek/web/ResultsTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -42,6 +42,7 @@ * @version $Id$ * @since 0.16 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class ResultsTest { diff --git a/src/test/java/org/jpeek/web/TkAppTest.java b/src/test/java/org/jpeek/web/TkAppTest.java index 35a91846..08c87e46 100644 --- a/src/test/java/org/jpeek/web/TkAppTest.java +++ b/src/test/java/org/jpeek/web/TkAppTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -43,6 +43,7 @@ * @version $Id$ * @since 0.5 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class TkAppTest { diff --git a/src/test/java/org/jpeek/web/TkIndexTest.java b/src/test/java/org/jpeek/web/TkIndexTest.java index 3d8a5537..6c38689f 100644 --- a/src/test/java/org/jpeek/web/TkIndexTest.java +++ b/src/test/java/org/jpeek/web/TkIndexTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -36,6 +36,7 @@ * @version $Id$ * @since 0.11 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class TkIndexTest { diff --git a/src/test/java/org/jpeek/web/TkMistakesTest.java b/src/test/java/org/jpeek/web/TkMistakesTest.java index 1eb0fba3..88151708 100644 --- a/src/test/java/org/jpeek/web/TkMistakesTest.java +++ b/src/test/java/org/jpeek/web/TkMistakesTest.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko @@ -37,6 +37,7 @@ * @version $Id$ * @since 0.14 * @checkstyle JavadocMethodCheck (500 lines) + * @checkstyle JavadocTagsCheck (500 lines) */ public final class TkMistakesTest { diff --git a/src/test/java/org/jpeek/web/package-info.java b/src/test/java/org/jpeek/web/package-info.java index aec386d5..a725757a 100644 --- a/src/test/java/org/jpeek/web/package-info.java +++ b/src/test/java/org/jpeek/web/package-info.java @@ -1,4 +1,4 @@ -/** +/* * The MIT License (MIT) * * Copyright (c) 2017-2019 Yegor Bugayenko From 2ac14ac5ab10e66163e11a771f7244c6e539a68f Mon Sep 17 00:00:00 2001 From: Gnusin Pavel Date: Tue, 12 Nov 2019 21:15:09 +0300 Subject: [PATCH 3/5] yegor256#308 remove underscores from numbers --- src/main/java/org/jpeek/Main.java | 1 + src/test/java/org/jpeek/MetricsTest.java | 12 +++++++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/jpeek/Main.java b/src/main/java/org/jpeek/Main.java index c60c3d1d..01ba7f27 100644 --- a/src/main/java/org/jpeek/Main.java +++ b/src/main/java/org/jpeek/Main.java @@ -42,6 +42,7 @@ * @author Yegor Bugayenko (yegor256@gmail.com) * @version $Id$ * @since 0.1 + * @todo #308:30min Remove all 'JavadocTagsCheck' suppression, fix qulice errors * @checkstyle JavadocVariableCheck (500 lines) * @checkstyle JavadocTagsCheck (500 lines) */ diff --git a/src/test/java/org/jpeek/MetricsTest.java b/src/test/java/org/jpeek/MetricsTest.java index 7efb25e3..aa0f4709 100644 --- a/src/test/java/org/jpeek/MetricsTest.java +++ b/src/test/java/org/jpeek/MetricsTest.java @@ -59,7 +59,13 @@ * @checkstyle JavadocTagsCheck (500 lines) */ @RunWith(Parameterized.class) -@SuppressWarnings({"PMD.AvoidDuplicateLiterals", "PMD.ExcessiveMethodLength"}) +@SuppressWarnings( + { + "PMD.AvoidDuplicateLiterals", + "PMD.ExcessiveMethodLength", + "PMD.UseUnderscoresInNumericLiterals" + } +) public final class MetricsTest { @Parameterized.Parameter @@ -219,13 +225,13 @@ public static Collection targets() { new Object[] { "IndirectlyRelatedPairs", "OCC", - 0.6_666_666_666_666_666d, + 0.6666666666666666d, }, new Object[] {"MethodMethodCalls", "OCC", 0.2d}, new Object[] { "MethodsWithDiffParamTypes", "OCC", - 0.3_333_333_333_333_333d, + 0.3333333333333333d, }, new Object[] {"NoMethods", "OCC", 0.0d}, new Object[] {"OneMethodCreatesLambda", "OCC", 0.0d}, From fd40c164b23ac6516c7781cce47d476a086dd2ab Mon Sep 17 00:00:00 2001 From: Gnusin Pavel Date: Tue, 19 Nov 2019 21:34:28 +0300 Subject: [PATCH 4/5] yegor256#308 more details for puzzle description --- src/main/java/org/jpeek/Main.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/jpeek/Main.java b/src/main/java/org/jpeek/Main.java index 01ba7f27..2c756556 100644 --- a/src/main/java/org/jpeek/Main.java +++ b/src/main/java/org/jpeek/Main.java @@ -42,7 +42,10 @@ * @author Yegor Bugayenko (yegor256@gmail.com) * @version $Id$ * @since 0.1 - * @todo #308:30min Remove all 'JavadocTagsCheck' suppression, fix qulice errors + * @todo #308:30min Due to introduce new version of qulice 0.18.17 there were + * many 'JavadocTagsCheck' suppression, so we need to fix that by remove + * author, version and since tags in all javadoc. After that remove + * 'JavadocTagsCheck' suppression. * @checkstyle JavadocVariableCheck (500 lines) * @checkstyle JavadocTagsCheck (500 lines) */ From 22023ab28df2865ffd2bbd05ccaf254194214a95 Mon Sep 17 00:00:00 2001 From: Gnusin Pavel Date: Wed, 20 Nov 2019 08:24:08 +0300 Subject: [PATCH 5/5] yegor256#308 leading spaces --- src/main/java/org/jpeek/Main.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/jpeek/Main.java b/src/main/java/org/jpeek/Main.java index 2c756556..6e6ad02b 100644 --- a/src/main/java/org/jpeek/Main.java +++ b/src/main/java/org/jpeek/Main.java @@ -43,9 +43,9 @@ * @version $Id$ * @since 0.1 * @todo #308:30min Due to introduce new version of qulice 0.18.17 there were - * many 'JavadocTagsCheck' suppression, so we need to fix that by remove - * author, version and since tags in all javadoc. After that remove - * 'JavadocTagsCheck' suppression. + * many 'JavadocTagsCheck' suppression, so we need to fix that by remove + * author, version and since tags in all javadoc. After that remove + * 'JavadocTagsCheck' suppression. * @checkstyle JavadocVariableCheck (500 lines) * @checkstyle JavadocTagsCheck (500 lines) */