Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize layer transformation in App #438

Open
HDouss opened this issue Apr 5, 2020 · 5 comments
Open

Optimize layer transformation in App #438

HDouss opened this issue Apr 5, 2020 · 5 comments

Comments

@HDouss
Copy link
Contributor

HDouss commented Apr 5, 2020

The analysis process (analyze method in App class) is building a chain of xsl layer files. The skeleton transformation by these layers is done for every xsl report, to be given as input for that report.:

new XslReport(
    chain.transform(skeleton), xsl,
    new ReportData("...", this.params)
)

chain.transform is called as many times as we have reports.
We could do this transformation once and for all and give the result as input to the reports.

This will make this process faster by doing this only once.

@0crat
Copy link
Collaborator

0crat commented Apr 5, 2020

@paulodamaso/z please, pay attention to this issue

@HDouss
Copy link
Contributor Author

HDouss commented Apr 21, 2020

@paulodamaso ping

1 similar comment
@HDouss
Copy link
Contributor Author

HDouss commented Apr 22, 2020

@paulodamaso ping

@paulodamaso
Copy link
Collaborator

@HDouss I think that it will be easier to do this after #461

@HDouss
Copy link
Contributor Author

HDouss commented Apr 23, 2020

@paulodamaso I don't really think it is related, here it is only about chain.transform(skeleton) that is repeated for every XslReport. But anyway, do you agree it has to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants