Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book 7, Section 233, Mindblast bonus missing #7

Open
lonevvolf opened this issue Nov 27, 2022 · 4 comments
Open

Book 7, Section 233, Mindblast bonus missing #7

lonevvolf opened this issue Nov 27, 2022 · 4 comments

Comments

@lonevvolf
Copy link

I believe there's an issue in Book 7, section 233. If you don't have Psi-Surge, there should still be double damage due to Mindblast. The doubling is not applied.

lonevvolf referenced this issue in lonevvolf/kaichronicles Nov 27, 2022
According to the text, also the Kai skill Mindblast doubles damage, not just Psi-surge.  This is my first mechanics change - please double check, but I tested the section in debug mode and it seems to work.

Fixes #7
@cracrayol
Copy link
Owner

Your fix is good if you start from book 1.
But if you start from another book and never take Mindblast, it's up to the player to choose if it has all kai disciplines or not when starting magnakai.
The best will be to ask him when starting a new game from book > 5 or when changing book serie if not previously started from first book of the serie (kai > magnakai / magnakai > grand master), but need more development than a simple fix.
https://www.projectaon.org/en/ReadersHandbook/MagnakaiDisciplines

@lonevvolf
Copy link
Author

Wow. This makes it very complicated. Does the app keep track of completed books?

@cracrayol
Copy link
Owner

You can get previous action charts with state.getPreviousBookActionChart(bookNumber).

And the current actionChart store all the disciplines selected by the user (see kaiDisciplines/magnakaiDisciplines/grandMasterDisciplines arrays)

@lonevvolf
Copy link
Author

I've dug into this - the app actually handles the disciplines from the previous books as one would expect. It does keep track of whether they actually have the skills, I don't think we need to add anything about getting Kai skills when starting Magnakai, unless this is mentioned somewhere in the rules/newsletters?
Regarding this specific case, well, what a mess. It's literally the only instance of having to check for Mindblast discipline in the books after the Kai series. The basic Mindblast bonus and even bonus multiplier for susceptible enemies is already implemented there. The only difference is in this section, it should double the ENDURANCE lost, instead of doubling the bonus. In order to get this to work correctly, we would have to change the book validation (so that a mindblast check is allowed in a Magnakai book), and also implement the checking of previous book disciplines for just this one case in all the books. I've implemented it locally, but it's such a change for one section that I really don't like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants